Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Full sync restart on bad block #844

Merged
merged 1 commit into from Mar 28, 2016
Merged

Full sync restart on bad block #844

merged 1 commit into from Mar 28, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Mar 27, 2016

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Mar 27, 2016
gavofyork
gavofyork reviewed Mar 28, 2016
View reviewed changes
sync/src/chain.rs
@@ -295,13 +294,17 @@ impl ChainSync {
}

/// Restart sync
pub fn restart(&mut self, io: &mut SyncIo) {
pub fn restart(&mut self, io: &mut SyncIo, full: bool) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full?

NikVolf
NikVolf reviewed Mar 28, 2016
View reviewed changes
sync/src/chain.rs
@@ -295,13 +294,18 @@ impl ChainSync {
}

/// Restart sync
pub fn restart(&mut self, io: &mut SyncIo) {
pub fn restart(&mut self, io: &mut SyncIo, after_bad_block: bool) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

fn restart_bad()  {
    restart()
    ... 
}

?

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 28, 2016
@gavofyork gavofyork merged commit f60d74b into beta Mar 28, 2016
@gavofyork gavofyork deleted the sync-beta branch March 28, 2016 13:49
@arkpar arkpar restored the sync-beta branch March 29, 2016 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkpar @gavofyork @NikVolf