Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Only return error log for rustls #9025

Merged
merged 1 commit into from Jul 2, 2018
Merged

Only return error log for rustls #9025

merged 1 commit into from Jul 2, 2018

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Jul 2, 2018

rustls appears to be sending too many logs. Especially sometimes you will see:

Sending warning alert CloseNotify

However, according to RFC 5246 section 7.2 (https://tools.ietf.org/html/rfc5246#section-7.2), this close notify message is just indication that the connection is being closed. However, this sometimes frightens user.

This PR modifies rustls log level from warning to error.

@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 2, 2018
@sorpaas sorpaas added this to the 1.12 milestone Jul 2, 2018
ordian
ordian reviewed Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any useful warnings from rustls apart from closing a connection? Do you think it's worth fixing in rustls?

5chdn
5chdn approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@5chdn 5chdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use rustls for anything critical, do we? So I appreciate this!

@5chdn
Copy link
Contributor

5chdn commented Jul 2, 2018

But we should additionally consider fixing this upstream, it should not be a warning.

@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 2, 2018
This was referenced Jul 2, 2018
Merged
Merged
@sorpaas
Copy link
Collaborator Author

sorpaas commented Jul 2, 2018

@ordian I opened upstream PR: rustls/rustls#182

@5chdn No we don't use it for anything critical -- it's used in fetcher, which handles price info fetch, and miner fixed endpoint notification (not the normal getwork and stratum protocol).

@Tbaut Tbaut mentioned this pull request Jul 2, 2018
Closed
@andresilva andresilva merged commit 202c54d into master Jul 2, 2018
dvdplm added a commit that referenced this pull request Jul 2, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
b9e310b 
* master:
  Only return error log for rustls (#9025)
  Update Changelogs for 1.10.8 and 1.11.5 (#9012)
@5chdn 5chdn deleted the sp-rustls-log branch July 3, 2018 09:41
5chdn pushed a commit that referenced this pull request Jul 6, 2018
@sorpaas @5chdn
Only return error log for rustls (#9025)
e76c566
ordian pushed a commit that referenced this pull request Jul 7, 2018
@sorpaas @ordian
Only return error log for rustls (#9025)
5085218
5chdn added a commit that referenced this pull request Jul 7, 2018
@5chdn
Stable: 1.10.9 backports (#9016)
23a9eef 
* parity-version: bump stable to 1.10.9

* scripts: remove md5 checksums (#8884)

* Add support for --chain tobalaba (#8870)

* Add support for --chain tobalaba

* Only return error log for rustls (#9025)

* Fixes for misbehavior reporting in AuthorityRound (#8998)

* aura: only report after checking for repeated skipped primaries

* aura: refactor duplicate code for getting epoch validator set

* aura: verify_external: report on validator set contract instance

* aura: use correct validator set epoch number when reporting

* aura: use epoch set when verifying blocks

* aura: report skipped primaries when generating seal

* aura: handle immediate transitions

* aura: don't report skipped steps from genesis to first block

* aura: fix reporting test

* aura: refactor duplicate code to handle immediate_transitions

* aura: let reporting fail on verify_block_basic

* aura: add comment about possible failure of reporting
5chdn added a commit that referenced this pull request Jul 9, 2018
@5chdn
Beta: 1.11.6 backports (#9015)
4ba600f 
* parity-version: bump beta to 1.11.6

* scripts: remove md5 checksums (#8884)

* Add support for --chain tobalaba

* Convert indents to tabs :)

* Fixes for misbehavior reporting in AuthorityRound (#8998)

* aura: only report after checking for repeated skipped primaries

* aura: refactor duplicate code for getting epoch validator set

* aura: verify_external: report on validator set contract instance

* aura: use correct validator set epoch number when reporting

* aura: use epoch set when verifying blocks

* aura: report skipped primaries when generating seal

* aura: handle immediate transitions

* aura: don't report skipped steps from genesis to first block

* aura: fix reporting test

* aura: refactor duplicate code to handle immediate_transitions

* aura: let reporting fail on verify_block_basic

* aura: add comment about possible failure of reporting

* Only return error log for rustls (#9025)

* Transaction Pool improvements (#8470)

* Don't use ethereum_types in transaction pool.

* Hide internal insertion_id.

* Fix tests.

* Review grumbles.

* Improve should_replace on NonceAndGasPrice (#8980)

* Additional tests for NonceAndGasPrice::should_replace.

* Fix should_replace in the distinct sender case.

* Use natural priority ordering to simplify should_replace.

* Minimal effective gas price in the queue (#8934)

* Minimal effective gas price.

* Fix naming, add test

* Fix minimal entry score and add test.

* Fix worst_transaction.

* Remove effective gas price threshold.

* Don't leak gas_price decisions out of Scoring.

* Never drop local transactions from different senders. (#9002)

* Recently rejected cache for transaction queue (#9005)

* Store recently rejected transactions.

* Don't cache AlreadyImported rejections.

* Make the size of transaction verification queue dependent on pool size.

* Add a test for recently rejected.

* Fix logging for recently rejected.

* Make rejection cache smaller.

* obsolete test removed

* obsolete test removed

* Construct cache with_capacity.

* Optimize pending transactions filter (#9026)

* rpc: return unordered transactions in pending transactions filter

* ethcore: use LruCache for nonce cache

Only clear the nonce cache when a block is retracted

* Revert "ethcore: use LruCache for nonce cache"

This reverts commit b382c19.

* Use only cached nonces when computing pending hashes.

* Give filters their own locks, so that they don't block one another.

* Fix pending transaction count if not sealing.

* Clear cache only when block is enacted.

* Fix RPC tests.

* Address review comments.

* A last bunch of txqueue performance optimizations (#9024)

* Clear cache only when block is enacted.

* Add tracing for cull.

* Cull split.

* Cull after creating pending block.

* Add constant, remove sync::read tracing.

* Reset debug.

* Remove excessive tracing.

* Use struct for NonceCache.

* Fix build

* Remove warnings.

* Fix build again.

* miner: add missing macro use for trace_time

* ci: remove md5 merge leftovers
ordian added a commit to ordian/parity that referenced this pull request Jul 9, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
352c5d9 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Never drop local transactions from different senders. (openethereum#9002)
  Precise HTTP or WebSockets for JSON-RPC options (openethereum#9027)
  Recently rejected cache for transaction queue (openethereum#9005)
  Make HashDB generic (openethereum#8739)
  Only return error log for rustls (openethereum#9025)
  Update Changelogs for 1.10.8 and 1.11.5 (openethereum#9012)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@5chdn 5chdn 5chdn approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sorpaas @5chdn @andresilva @ordian @niklasad1