This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
executive tracing cleanup #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /// This funtion should be used to execute transaction. | ||
| pub fn transact(&'a mut self, t: &SignedTransaction, options: TransactOptions) -> Result<Executed, Error> { | ||
| let check = options.check_nonce; | ||
| match options.tracing { | ||
| true => self.transact_with_tracer(t, check, ExecutiveTracer::default()), |
There was a problem hiding this comment.
just pull out the final param into the conditional
perhapes use inline if
There was a problem hiding this comment.
just pull out the final param into the conditional
I wanted, but I can't.
let t = if options.tracing {
ExecutiveTracer::default()
else {
NoopTracer
}This is not valid expression, because of the type difference. And if I Box the tracer, the type information is lost.
gavofyork
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracertrait implementationsresultfield fromTraceActionvariants toTraceresultTraceAction::Unknownvariantif/if letstatements and moving tracing logic to tracer// this pr is prelude to db tracing module (more to come tomorrow)