Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Even more detailed errors for transaction queue #969

Merged
merged 3 commits into from Apr 18, 2016
Merged

Conversation

tomusdrw
Copy link
Collaborator

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Apr 18, 2016

macro_rules! check_too_cheap {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a regular function returning Result<(), TransactionError > instead of a macro?
try!(check_limit(...))

@arkpar arkpar added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 18, 2016
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Apr 18, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 18, 2016
@gavofyork gavofyork merged commit caf4d17 into master Apr 18, 2016
@gavofyork gavofyork deleted the tx_limit_errors branch April 18, 2016 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants