This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
querying extras separated to its own module #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A8-looksgood 🦄
| } | ||
|
|
||
| let mut write_details = self.block_details.write().unwrap(); | ||
| BatchWriter::new(&batch, &mut write_details) |
There was a problem hiding this comment.
An object is created just to call a single method. Could it be a simple function instead?
Same for DatabaseReader
arkpar
added
A6-mustntgrumble 💦
debris
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am duplicating the whole logic of querying extras in fatdb, so I made it generic.