Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure separation of dependencies in Substrate, Cumulus, Polkadot is maintained #1318

Open
nuke-web3 opened this issue Aug 30, 2023 · 0 comments
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request.

Comments

@nuke-web3
Copy link
Contributor

nuke-web3 commented Aug 30, 2023

In the monorepo, I propose we ensure separation of dependencies in Substrate, Cumulus, Polkadot is maintained, so these can be independent of each other long term. It feels easy to bring in dependencies across boundaries that will erode the independence of the three projects.

If I understand correctly, this is the dependency tree that should be enforced:

graph TD;
    Cumulus-->Substrate;
    Cumulus-->Polkadot;
    Polkadot-->Substrate;

I see there is a Substrate specific script that could be repurposed/expanded for Cumulus, Polkadot, and the whole monorepo:

https://github.com/paritytech/polkadot-sdk/blob/43c0c09bcb9a4db0856598dd07357c0b7292bb84/.gitlab/ensure-deps.sh#L16-L23CI

For reference this blog highlights the easy coupling we inevitably will see hidden by the directory structure, but not the dependency graph.

@nuke-web3 nuke-web3 added I5-enhancement An additional feature request. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

1 participant