Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsystem-bench: Generate PoV sizes for TestConfiguration implicitly #3599

Open
AndreiEres opened this issue Mar 6, 2024 · 0 comments · May be fixed by #3621
Open

subsystem-bench: Generate PoV sizes for TestConfiguration implicitly #3599

AndreiEres opened this issue Mar 6, 2024 · 0 comments · May be fixed by #3621
Assignees
@AndreiEres
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@AndreiEres
Copy link
Contributor

When preparing a test configuration for regression testing we generate PoV sizes explicitely:

polkadot-sdk/polkadot/node/network/availability-recovery/tests/availability-recovery-regression-bench.rs

Line 52 in 475e7a1

config.generate_pov_sizes();

It would be better to hide this as part of the TestConfiguration initialization.
@AndreiEres AndreiEres added R0-silent Changes should not be mentioned in any release notes C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T12-benchmarks This PR/Issue is related to benchmarking and weights. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 6, 2024
@olaitanade olaitanade linked a pull request Mar 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiEres AndreiEres

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

subsystem-bench: Generate PoV sizes for TestConfiguration implicitly olaitanade/polkadot-sdk
1 participant
@AndreiEres