Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider implementing a checked_mutate for all the mutations in the staking ledger related storage items #3697

Open
gpestana opened this issue Mar 14, 2024 · 0 comments
Open

Consider implementing a checked_mutate for all the mutations in the staking ledger related storage items #3697

gpestana opened this issue Mar 14, 2024 · 0 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@gpestana
Copy link
Contributor

To prevent issues like what happened in #3245, consider implementing a checked_mutate for all the mutations in the staking ledger related storage items.

The check_mutate should fail in case the state of the storage is incorrect after the mutation. Transactional should take care of the rest.
@gpestana gpestana mentioned this issue Mar 19, 2024
Open
@gpestana gpestana added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I10-unconfirmed Issue might be valid, but it's not yet known. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
(Nominated) Proof of Stake
Status: 📕 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gpestana