Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRAME] Remove deprecated calls from treasury pallet #3800

Open
muharem opened this issue Mar 22, 2024 · 4 comments
Open

[FRAME] Remove deprecated calls from treasury pallet #3800

muharem opened this issue Mar 22, 2024 · 4 comments
Assignees
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.

Comments

@muharem
Copy link
Contributor

muharem commented Mar 22, 2024

As part of the deprecation process #138 the next call needs to be removed:

  • pallet_treasury.propose_spend
  • pallet_treasury.reject_proposal
  • pallet_treasury.approve_proposal

Scope:

  • remove deprecated calls;
  • set explicit coded indexes for Error and Event enums, remove unused variants and keep the same indexes for the rest;
  • remove unused Config's type parameters;
  • remove irrelevant tests and adopt relevant using old api;
  • remove banchmarks for removed calls;

mentor: @muharem

@muharem muharem added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I4-refactor Code needs refactoring. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 22, 2024
@chungquantin
Copy link
Contributor

Hi, I am keen on working on this issue

@chungquantin
Copy link
Contributor

chungquantin commented Mar 25, 2024

@muharem I have created a PR for this issue. Could you please help me to review? There is only only task I am not sure.

set explicit coded indexes for Error and Event enums, remove unused variants and keep the same indexes for the rest;

I am trying to find an example of other people works for explicit coded indexes used in this codebase but could not find one. Could you suggest me an approach for this?

@muharem
Copy link
Contributor Author

muharem commented Mar 25, 2024

@chungquantin just commented, let me know if something not clear yet

@shawntabrizi
Copy link
Contributor

I would like to also include these changes into any new release of the treasury pallet: https://github.com/paritytech/polkadot-sdk/pull/3970/files

So that we have only one set of breaking changes to the treasury pallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

3 participants