Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking force_unbond #414

Open
kianenigma opened this issue Apr 26, 2023 · 4 comments · May be fixed by #3811
Open

Staking force_unbond #414

kianenigma opened this issue Apr 26, 2023 · 4 comments · May be fixed by #3811
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Apr 26, 2023

Currently, as a nominator or validator, your request to fully unbond can fail if you are not chilled yet.

The right fix is for the UI to detect this and batch it with a chill.

A force_unbond can help clarify this, and is not that much overhead on the chain runtime. under the hood, it would be an optional chill, followed by unbond.

@rossbulat
Copy link
Contributor

Just to clarify, can this force_unbond be a permissionless call if the staker is already chilled?

The ability to remove inactive stakers from storage like this would also allow us to target those who have a unique stash & controller pair, & could speed up controller account removal.

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. and removed T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Feb 5, 2024
@kianenigma
Copy link
Contributor Author

Just to clarify, can this force_unbond be a permissionless call if the staker is already chilled?

The ability to remove inactive stakers from storage like this would also allow us to target those who have a unique stash & controller pair, & could speed up controller account removal.

Not really, this is a different concern. You might want to chill yourself while staying bonded for various reasons, and I don't see why we should prevent users from being in this state.

I personally know stakers who generally keep their funds bonded but chilled for safety.

@dharjeezy
Copy link
Contributor

Hello @kianenigma i will like to work on this.

@Ank4n
Copy link
Contributor

Ank4n commented Mar 21, 2024

Currently, as a nominator or validator, your request to fully unbond can fail if you are not chilled yet.

The right fix is for the UI to detect this and batch it with a chill.

A force_unbond can help clarify this, and is not that much overhead on the chain runtime. under the hood, it would be an optional chill, followed by unbond.

A better solution might be to improve the checks in unbond which chills if it is full unbond. But it should never allow ledger active balance to be between 0 and MinNominatorBond.

This was referenced Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet.
Projects
Status: 📕 Backlog
Development

Successfully merging a pull request may close this issue.

5 participants