Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCM] Move XCM into its own repo #610

Open
franciscoaguirre opened this issue Jun 15, 2023 · 4 comments
Open

[XCM] Move XCM into its own repo #610

franciscoaguirre opened this issue Jun 15, 2023 · 4 comments
Assignees
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Jun 15, 2023

We should move XCM into its own repo as a first step for decoupling it with Polkadot.

The overview of open PRs touching the xcm directory

PR Author Num of Approvals Merge before, Move to or Not Relevant
[pallet_xcm] Customizable/extendable remote_message estimation @bkontur 1 merge (could introduce "xcm standard weights")
Changed T::BlockWeights::get().max_block -> Weight::MAX @bkontur 3 depends on line above
nonfungibles adapter v2 @vstam1 0 merge
[xcm] Extend haul_blob with Channel + include NetworkId to channel id @bkontur 0 move
Make AssetId and MultiLocation non-Copy @koute 1
Introduce XcmFeesToAccount fee manager @KiChjang 3
Introduce transactional processing for xcm instructions @vstam1 0 move
@xlc
Copy link
Contributor

xlc commented Jun 15, 2023

I agree with this but wondering how this affects the mono effort.

@gavofyork
Copy link
Member

gavofyork commented Jun 22, 2023

I think it's fine. Including it under polkadot was only ever meant to be temporary while XCM was evolving fast. As the design becomes more stable and improvements become incremental then I think it'll be really good to introduce proper versioning and publishing. In particular I look forward to iterating fast on XCMv4 in the xcm/xcm-executor/-builder/-pallet while keeping the XCM used in Polkadot stable at v3 until v4 is audited and stabilises. This was a big pain point with the delivery of XCMv3.

@vstam1
Copy link
Contributor

vstam1 commented Jul 31, 2023

Above I created an overview of all the open PRs that touch the xcm directory that should either be merged before we move to the new repo, or that should be moved to the new repo. I added all the PRs that where opened in 2023. If there are PRs that I missed or where opened before 2023 and should be added, add them to the overview. I would like to ask the authors of the PRs to add to the last column if the PR should be merged before, they will move the PR over to the new repo or if the PR is not relevant anymore. Keep in mind that merging before will block the move to the new repo.

@athei
Copy link
Member

athei commented Aug 1, 2023

I agree with this but wondering how this affects the mono effort.

I think what this means is that XCM has to be stand alone and can no longer depend on Substrate since that will move in with Polkadot (monorepo) and would create a cyclic dependency.

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

6 participants