Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-client-api is not named correctly #7

Open
kianenigma opened this issue May 24, 2023 · 2 comments
Open

sc-client-api is not named correctly #7

kianenigma opened this issue May 24, 2023 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.

Comments

@kianenigma
Copy link
Contributor

as per our crate naming convention, -client- is redundant because it is already implied by sc.

Moreover, if I want to nitpick, sp-consensus-common should have only been named sp-consensus as there is no /common in its Cargo.toml path.
@the-right-joyce the-right-joyce transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. and removed I7-refactor labels Aug 25, 2023
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Feb 5, 2024
@kianenigma
Copy link
Contributor Author

@ParityReleases what is the consequence of this, as the crate will be renamed? if it is a hassle, we might as well just ignore it. It does not seem like anyone other than me cares about the name :)

@kayabaNerve
Copy link

I appreciate clarity/consistency improvements and subscribed to this issue when I noticed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring.
Projects
SDK Node
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kianenigma @kayabaNerve @the-right-joyce