Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Flaky test in approval-distribution #5417

Closed
kianenigma opened this issue Apr 28, 2022 · 4 comments · Fixed by #5427
Closed

Flaky test in approval-distribution #5417

kianenigma opened this issue Apr 28, 2022 · 4 comments · Fixed by #5427
Labels
I5-tests Tests need fixing, improving or augmenting.

Comments

@kianenigma
Copy link
Contributor

See: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1530940 from the totally unrelated #5405

cc @drahnr @eskimor

@kianenigma kianenigma added the I5-tests Tests need fixing, improving or augmenting. label Apr 28, 2022
@eskimor
Copy link
Member

eskimor commented Apr 29, 2022

LOL, I have to reduce that timeout to 1 microsecond to reproduce locally. Either those CI machines must be under really heavy load for a 100ms timeout to hit or something else weird is going on. I guess real heavy load, with context switches can explain even 100000x slower execution. 🤷 Will nevertheless have a closer look, whether it could also be something else.

@eskimor
Copy link
Member

eskimor commented Apr 29, 2022

Nope, it really seems to be that slow. I'll increase the timeout some more to make it even less likely to hit.

@eskimor
Copy link
Member

eskimor commented Apr 29, 2022

If this keeps being a problem, we might also increase the channel capacity a bit:

pub tx: SingleItemSink<FromOverseer<M>>,

@eskimor
Copy link
Member

eskimor commented Apr 29, 2022

#5427

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants