Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Polkadot v1.0.0 Release checklist #7487

Closed
11 of 14 tasks
github-actions bot opened this issue Jul 11, 2023 · 8 comments
Closed
11 of 14 tasks

Polkadot v1.0.0 Release checklist #7487

github-actions bot opened this issue Jul 11, 2023 · 8 comments
Assignees

Comments

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Release Checklist

This is the release checklist for Polkadot v1.0.0. All following
checks should be completed before publishing a new release of the
Polkadot/Kusama/Westend/Rococo runtime or client. The current release candidate can be
checked out with git checkout release-v1.0.0

Runtime Releases

These checks should be performed on the codebase prior to forking to a release-
candidate branch.

  • Verify spec_version has been incremented since the
    last release for any native runtimes from any existing use on public
    (non-private) networks. If the runtime was published (release or pre-release), either
    the spec_version or impl must be bumped.
  • Verify previously completed migrations are
    removed for any public (non-private/test) networks.
  • Verify pallet and extrinsic ordering has stayed
    the same. Bump transaction_version if not.
  • Verify new extrinsics have been correctly whitelisted/blacklisted for
    proxy filters.
  • Verify benchmarks have been updated for any modified
    runtime logic.

The following checks can be performed after we have forked off to the release-
candidate branch or started an additional release candidate branch (rc-2, rc-3, etc)

  • Verify new migrations complete successfully, and the
    runtime state is correctly updated for any public (non-private/test)
    networks.
  • Verify Polkadot JS API are up to date with the latest
    runtime changes.
  • Check with the Signer's team to make sure metadata update QR are lined up
  • Push runtime upgrade to Westend and verify network stability.

All Releases

@coderobe
Copy link
Contributor

@coderobe coderobe self-assigned this Jul 11, 2023
@coderobe
Copy link
Contributor

some of the benchmarks got killed yesterday (gitlab maintenance?)

@ordian
Copy link
Member

ordian commented Jul 12, 2023

Running https://github.com/paritytech/pvf-checker/tree/release-v1.0.0 on Kusama and Polkadot for existing PVFs revealed no problems. Other than ParaId 2053 on Polkadot is not a valid wasm (InvalidMagic).

Pvf checker on Kusama
/target/release/pvf-checker pvf-check --rpc-url 'wss://kusama-rpc.polkadot.io:443'
Fetching parachain PVFs... SUCCESS (41 PVFs)
Pre-checking Id(1000): SUCCESS (6922ms)
Pre-checking Id(1001): SUCCESS (6189ms)
Pre-checking Id(1002): SUCCESS (4378ms)
Pre-checking Id(2000): SUCCESS (10777ms)
Pre-checking Id(2001): SUCCESS (11638ms)
Pre-checking Id(2004): SUCCESS (7690ms)
Pre-checking Id(2007): SUCCESS (9802ms)
Pre-checking Id(2011): SUCCESS (3210ms)
Pre-checking Id(2012): SUCCESS (7822ms)
Pre-checking Id(2015): SUCCESS (5938ms)
Pre-checking Id(2023): SUCCESS (10245ms)
Pre-checking Id(2024): SUCCESS (7650ms)
Pre-checking Id(2048): SUCCESS (5912ms)
Pre-checking Id(2084): SUCCESS (8585ms)
Pre-checking Id(2085): SUCCESS (11062ms)
Pre-checking Id(2087): SUCCESS (13164ms)
Pre-checking Id(2088): SUCCESS (9866ms)
Pre-checking Id(2090): SUCCESS (7590ms)
Pre-checking Id(2092): SUCCESS (9115ms)
Pre-checking Id(2095): SUCCESS (6997ms)
Pre-checking Id(2096): SUCCESS (7833ms)
Pre-checking Id(2100): SUCCESS (6015ms)
Pre-checking Id(2101): SUCCESS (5319ms)
Pre-checking Id(2105): SUCCESS (8420ms)
Pre-checking Id(2106): SUCCESS (9698ms)
Pre-checking Id(2110): SUCCESS (8339ms)
Pre-checking Id(2113): SUCCESS (5932ms)
Pre-checking Id(2114): SUCCESS (7168ms)
Pre-checking Id(2119): SUCCESS (8128ms)
Pre-checking Id(2121): SUCCESS (7020ms)
Pre-checking Id(2124): SUCCESS (12712ms)
Pre-checking Id(2125): SUCCESS (6425ms)
Pre-checking Id(2129): SUCCESS (10846ms)
Pre-checking Id(2222): SUCCESS (6346ms)
Pre-checking Id(2236): SUCCESS (11556ms)
Pre-checking Id(2239): SUCCESS (7418ms)
Pre-checking Id(2241): SUCCESS (9275ms)
Pre-checking Id(2245): SUCCESS (5220ms)
Pre-checking Id(2257): SUCCESS (7412ms)
Pre-checking Id(2261): SUCCESS (4607ms)
Pre-checking Id(2267): SUCCESS (4169ms)
Pvf checker on Polkadot
❯ ./target/release/pvf-checker pvf-check --rpc-url 'wss://rpc.polkadot.io:443' --skip 2053
Fetching parachain PVFs... SUCCESS (46 PVFs)
Pre-checking Id(1000): SUCCESS (5410ms)
Pre-checking Id(1001): SUCCESS (5841ms)
Pre-checking Id(1002): SUCCESS (4855ms)
Pre-checking Id(2000): SUCCESS (12224ms)
Pre-checking Id(2002): SUCCESS (10689ms)
Pre-checking Id(2004): SUCCESS (10157ms)
Pre-checking Id(2006): SUCCESS (9602ms)
Pre-checking Id(2007): SUCCESS (5526ms)
Pre-checking Id(2008): SUCCESS (8413ms)
Pre-checking Id(2011): SUCCESS (10627ms)
Pre-checking Id(2012): SUCCESS (13958ms)
Pre-checking Id(2013): SUCCESS (9327ms)
Pre-checking Id(2019): SUCCESS (10634ms)
Pre-checking Id(2021): SUCCESS (7694ms)
Pre-checking Id(2026): SUCCESS (9805ms)
Pre-checking Id(2027): SUCCESS (3464ms)
Pre-checking Id(2030): SUCCESS (11537ms)
Pre-checking Id(2031): SUCCESS (11888ms)
Pre-checking Id(2032): SUCCESS (10771ms)
Pre-checking Id(2034): SUCCESS (8695ms)
Pre-checking Id(2035): SUCCESS (8014ms)
Pre-checking Id(2037): SUCCESS (6989ms)
Pre-checking Id(2039): SUCCESS (3325ms)
Pre-checking Id(2040): SUCCESS (6715ms)
Pre-checking Id(2043): SUCCESS (6861ms)
Pre-checking Id(2046): SUCCESS (10331ms)
Pre-checking Id(2048): SUCCESS (8697ms)
Pre-checking Id(2051): SUCCESS (5754ms)
Pre-checking Id(2052): SUCCESS (5439ms)
Skipping Id(2053):
Pre-checking Id(2055): SUCCESS (4487ms)
Pre-checking Id(2056): SUCCESS (8237ms)
Pre-checking Id(2058): SUCCESS (1935ms)
Pre-checking Id(2086): SUCCESS (7318ms)
Pre-checking Id(2090): SUCCESS (7506ms)
Pre-checking Id(2091): SUCCESS (2873ms)
Pre-checking Id(2092): SUCCESS (6905ms)
Pre-checking Id(2093): SUCCESS (7844ms)
Pre-checking Id(2094): SUCCESS (10986ms)
Pre-checking Id(2097): SUCCESS (5610ms)
Pre-checking Id(2101): SUCCESS (6593ms)
Pre-checking Id(2104): SUCCESS (9713ms)
Pre-checking Id(2106): SUCCESS (4370ms)
Pre-checking Id(3333): SUCCESS (5454ms)
Pre-checking Id(3334): SUCCESS (13241ms)
Pre-checking Id(3336): SUCCESS (4140ms)

@kogeler
Copy link

kogeler commented Jul 19, 2023

@coderobe
When I try to build it I have some errors. Cargo target is empty.
cmd: "cargo build --release"
Rust stable: 1.70.0 or 1.71.0
polkadot-build-error.txt

@ggwpez
Copy link
Member

ggwpez commented Jul 19, 2023

@kogeler cannot reproduce.

cd polkadot
git checkout 1ed6e2e50a4ce61f6cda46a730efc11a07b6ebb3
cargo build --release

Works for me on stable 1.70 (no nightly installed).

@coderobe
Copy link
Contributor

released

@IkerAlus
Copy link

IkerAlus commented Jul 20, 2023

transaction_version has been bumped for this release as per this commit, is this correct?

@coderobe
Copy link
Contributor

transaction_version has been bumped for this release as per this commit, is this correct?

We no longer release the runtimes from here, that'll happen on the fellowship side - That commit & the other runtime related release maintenance commits on that branch still need to be ported over though.

tl;dr: it will likely end up bumped to that in their runtime release yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants