Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runtime feature detection for avx2 #29

Open
alindima opened this issue Dec 5, 2023 · 1 comment
Open

add runtime feature detection for avx2 #29

alindima opened this issue Dec 5, 2023 · 1 comment

Comments

@alindima
Copy link
Contributor

alindima commented Dec 5, 2023

Currently, the avx feature is compile-time determined, based on the CPUID features of the processor and/or RUSTFLAGS value.

Before cutting a new release that includes #10, we must add runtime feature detection.
Otherwise, one could use pre-compiled binaries from a platform that supports avx and would likely run into an illegal instruction when running on a platform that doesn't.

@ordian
Copy link
Member

ordian commented Dec 12, 2023

Take a look at dalek-cryptography/curve25519-dalek#523 for inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants