Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Review-Bot fetch the latest information of a PR instead of using the action payload #122

Closed
Tracked by #8
rzadp opened this issue May 17, 2024 · 2 comments · Fixed by #128
Closed
Tracked by #8

Make Review-Bot fetch the latest information of a PR instead of using the action payload #122

rzadp opened this issue May 17, 2024 · 2 comments · Fixed by #128
Assignees
@Bullrich
Labels
bug Something isn't working

Comments

@rzadp
Copy link
Contributor

rzadp commented May 17, 2024

Here: polkadot-fellows/runtimes#314

The last commit and the approval came within 1 minute of each other.
Possibly it created a race condition, resulting in a bug - re-requesting an approval, which was unexpected.
@Bullrich Bullrich self-assigned this May 21, 2024
@Bullrich Bullrich added the bug Something isn't working label May 21, 2024
@Bullrich
Copy link
Collaborator

Bullrich commented Jul 2, 2024

Solution

Make review-bot fetch the latest information of the PR and not use the event.

@Bullrich Bullrich changed the title Investigate race-condition between a pushed commit and a review Make Review-Bot fetch the latest information of a PR instead of using the action payload Jul 2, 2024
@Bullrich Bullrich mentioned this issue Jul 2, 2024
Open
@Bullrich
Copy link
Collaborator

Bullrich commented Jul 3, 2024

This was already solved in #94

@Bullrich Bullrich closed this as completed Jul 3, 2024
@Bullrich Bullrich linked a pull request Jul 3, 2024 that will close this issue
updated github actions to use latest major version #128
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated github actions to use latest major version paritytech/review-bot
2 participants
@Bullrich @rzadp