Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode from &mut Input rather than from &mut &[u8] to align with scale_codec #10

Open
jsdw opened this issue Nov 21, 2022 · 0 comments
Open

Comments

@jsdw
Copy link
Collaborator

jsdw commented Nov 21, 2022

It would be nice if this library would play well with parity-scale-codec's Decode trait. this trait takes in an &mut Input (something implementing the Input trait), but because scale-decode only accepts &mut &[u8], we can't easily use it as part of that decode impl.

Let's consider supporting &mut Input instead to allow these crates to play nicely together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant