use scale-bits for BitSequence decoding etc and enable WASM test #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Sep 20, 2022
niklasad1
approved these changes
Sep 20, 2022
niklasad1
reviewed
Sep 21, 2022
| uses: actions-rs/cargo@v1.0.3 | ||
| with: | ||
| command: check | ||
| args: --all-targets --all-features --target wasm32-unknown-unknown |
There was a problem hiding this comment.
this looks funny but --all-targets actually imply that is compiles for test and bench I guess?
There was a problem hiding this comment.
Yeah that's my understanding of it! It's not really important to have here but I thought we may as well try and push for everything to compile to wasm when possible.. shrug :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've consolidated bit sequence handling into the scale-bits crate, so lean on that and remove encode/decode logic from here.
Also add a CI check that we can compile the crate to WASM.
And for the sake of expediency I've also prepped for the next release.
Closes #2