encode: Encode nested tuples properly #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that nested tuples inside sequences can be encoded properly.
Prior to this encoding a
Vec<(u8, u16)>
would not work properly with dynamic values ofThis is because
find_sequence_candidate
function did assume that the last type of the value is the "end-type" of the sequence.Instead, if we deal with tuple/composite inside a sequence (sequence or array otherwise), then recurse back to
encode_composite
with proper parameters (unflattened).Detected by: paritytech/subxt#982.
// @paritytech/subxt-team