-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support camelCase for parachain chain spec #2360
Comments
Sorry but I'm in favor of well-defined formats, and against having to make approximate guesses. The objective of a chain spec document is to describe a chain that the client doesn't know about. It's similar to a configuration file destined to the client. I feel like it kind of kills the point if each chain has their own tweaks to the format of their spec. Assuming that your chain spec doesn't change, it's a one off effort to manually change the fields to make it work with smoldot, which I think is acceptable? |
That being said, if the problem is just with I just want the smoldot chain specs to be well-defined, and their differences with cumulus chain specs to be clear and trackable. |
Ok. We don't plan to customize our chain spec so that's fine. We do want to use camelCase for the sake of consistency. It is cumulus issue using inconsistent case here. |
Firstly the chain spec parsing should not
deny_unknown_fields
. Parachain may want to have custom fields for whatever reason and it will be poor compatibility to reject them.Secondly I don't know why cumulus itself is mixing both camelCase and default snake_case in chain spec, but at Acala we are all using camelCase, and it is incompatible to smoldot currently. It will be good if both cases can be handled.
The text was updated successfully, but these errors were encountered: