Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement listening for GrandPa commit messages #366

Closed
tomaka opened this issue Jan 15, 2021 · 1 comment · Fixed by #846
Closed

Implement listening for GrandPa commit messages #366

tomaka opened this issue Jan 15, 2021 · 1 comment · Fixed by #846

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 15, 2021

The light client needs to listen to GrandPa commit messages (which are being gossiped around) to determine which blocks get finalized.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 24, 2021

Rough code design draft:

A good part of the GrandPa logic should go in the src/network module.
The network/service code should get some sort of set_grandpa_info(authorities_set_id: u??, round_number: u??) method that sends out GrandPa neighbour packets.

The network module should also verify the commit messages (or give ways to verify commit messages, if directly verifying isn't possible) and report that.

The chain/sync/all module should get a set_finalized_block method that updates the locally-known finalized block.
The "outcome" objects reported by chain/sync/all should also indicate changes in the authorities set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant