Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Aggregate + Clean runtime fixed point arithmetic types #3189

Closed
7 tasks
kianenigma opened this issue Jul 24, 2019 · 2 comments · Fixed by #3456
Closed
7 tasks

Aggregate + Clean runtime fixed point arithmetic types #3189

kianenigma opened this issue Jul 24, 2019 · 2 comments · Fixed by #3456
Assignees
Labels
I7-refactor Code needs refactoring. J0-enhancement An additional feature request.
Milestone

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Jul 24, 2019

Currently we have:

  • Perbill
  • Permill
  • PerU128
  • Fixed64

Need to add:

  • RationalU32
  • Clean up PerU128
  • Make the Api and exposed functions of all of them consistent. All should expose normal, checked, saturating etc.

Maybe

CC @thiolliere

@kianenigma kianenigma added the J0-enhancement An additional feature request. label Jul 24, 2019
@kianenigma kianenigma added this to the As-and-when milestone Jul 24, 2019
@kianenigma kianenigma added the I7-refactor Code needs refactoring. label Jul 24, 2019
@thiolliere
Copy link
Contributor

instead of RationalU32 I would name it FractionalU32 because it can't exceed 1, or maybe we can make that it can exceed one.

@xlc
Copy link
Contributor

xlc commented Jul 24, 2019

Those types will be very useful to ink as well. Does it make sense to move them into a standalone fixed point rust crate?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring. J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants