Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & cleanup memory cache #695

Closed
wants to merge 8 commits into from
Closed

Refactor & cleanup memory cache #695

wants to merge 8 commits into from

Conversation

Robbepop
Copy link
Member

No description provided.

@Robbepop Robbepop changed the title Optimize memory cache Refactor & cleanup memory cache Feb 25, 2023
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Feb 25, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.56ms 1.86ms 🔴 19.02% 1.09ms 1.09ms 🟢 0.62% 🟢 -42%
execute/
bare_call_0/typed
1.12ms 1.05ms 🟢 -6.38% 736.61µs 724.18µs 🟢 -1.81% 🟢 -31%
execute/
bare_call_1
1.49ms 1.88ms 🔴 25.92% 1.18ms 1.28ms 🔴 8.87% 🟢 -32%
execute/
bare_call_16
2.32ms 2.36ms 🔴 2.44% 3.13ms 3.52ms 🔴 12.73% 🟢 49%
execute/
bare_call_16/typed
1.58ms 1.66ms 🔴 6.48% 1.52ms 1.68ms 🔴 10.60% 🟢 1%
execute/
bare_call_1/typed
1.14ms 1.16ms 🔴 2.63% 982.30µs 964.70µs 🟢 -1.74% 🟢 -17%
execute/
bare_call_4
1.61ms 1.79ms 🔴 11.39% 1.63ms 1.62ms 🟢 -0.50% 🟢 -10%
execute/
bare_call_4/typed
1.13ms 1.32ms 🔴 16.81% 1.03ms 1.02ms 🟢 -1.54% 🟢 -23%
execute/
br_table
1.16ms 1.22ms ⚪ 3.80% 1.19ms 1.18ms ⚪ -0.48% 🟢 -3%
execute/
count_until
650.92µs 638.72µs 🟢 -1.86% 1.21ms 1.56ms 🔴 28.62% 🔴 144%
execute/
factorial_iterative
320.87µs 322.35µs ⚪ 0.49% 509.43µs 691.00µs 🔴 35.64% 🔴 114%
execute/
factorial_recursive
625.99µs 623.68µs ⚪ -0.47% 1.09ms 1.22ms 🔴 12.21% 🟡 96%
execute/
fib_iterative
1.46ms 1.47ms ⚪ 0.26% 2.45ms 3.42ms 🔴 39.79% 🔴 133%
execute/
fib_recursive
5.72ms 5.83ms 🔴 1.96% 9.78ms 11.06ms 🔴 13.09% 🟡 90%
execute/
global_bump
892.44µs 817.66µs 🟢 -8.39% 2.26ms 1.77ms 🟢 -21.28% 🔴 117%
execute/
global_const
685.00µs 678.72µs ⚪ -0.82% 1.45ms 1.85ms 🔴 26.84% 🔴 172%
execute/
host_calls
27.45µs 26.94µs 🟢 -1.66% 38.36µs 38.32µs ⚪ -0.16% 🟢 42%
execute/
memory_fill
1.20ms 1.24ms 🔴 3.27% 2.09ms 2.84ms 🔴 35.88% 🔴 129%
execute/
memory_sum
1.21ms 1.19ms 🟢 -1.56% 2.12ms 2.71ms 🔴 27.44% 🔴 127%
execute/
memory_vec_add
2.39ms 2.42ms 🔴 1.46% 4.90ms 5.81ms 🔴 18.41% 🔴 140%
execute/
recursive_is_even
1.16ms 1.16ms ⚪ -0.31% 1.87ms 2.08ms 🔴 10.93% 🟡 79%
execute/
recursive_ok
144.15µs 145.40µs ⚪ 0.78% 261.72µs 289.53µs 🔴 10.68% 🟡 99%
execute/
recursive_scan
176.06µs 174.20µs ⚪ -1.01% 312.55µs 361.83µs 🔴 15.79% 🔴 108%
execute/
recursive_trap
14.24µs 14.38µs ⚪ 0.90% 26.23µs 29.13µs 🔴 11.12% 🔴 103%
execute/
regex_redux
523.25µs 541.14µs 🔴 3.40% 997.58µs 1.17ms 🔴 17.11% 🔴 116%
execute/
rev_complement
462.91µs 466.50µs ⚪ 0.81% 838.23µs 999.27µs 🔴 19.24% 🔴 114%
execute/
tiny_keccak
329.37µs 327.71µs ⚪ -0.63% 641.74µs 854.45µs 🔴 33.11% 🔴 161%
execute/
trunc_f2i
765.59µs 780.15µs 🔴 1.84% 1.45ms 1.63ms 🔴 13.45% 🔴 109%
instantiate/
wasm_kernel
50.93µs 54.66µs 🔴 5.77% 53.81µs 56.00µs 🔴 3.50% 🟢 2%
translate/
erc1155
232.85µs 233.98µs ⚪ 0.30% 446.64µs 452.01µs ⚪ 1.14% 🟡 93%
translate/
erc20
113.27µs 113.71µs ⚪ 0.39% 217.18µs 217.81µs ⚪ 0.63% 🟡 92%
translate/
erc721
160.40µs 162.28µs 🔴 1.30% 314.57µs 317.70µs ⚪ 1.10% 🟡 96%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.35% 0.00ns 0.00ns ⚪ 0.70% 🟢 0%
translate/
wasm_kernel
4.09ms 4.12ms ⚪ 0.22% 8.30ms 8.36ms ⚪ 0.62% 🔴 103%

Link to pipeline

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #695 (2ba4a71) into master (43ce25d) will increase coverage by 0.00%.
The diff coverage is 90.32%.

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files         100      100           
  Lines        8506     8508    +2     
=======================================
+ Hits         6891     6893    +2     
  Misses       1615     1615           
Impacted Files Coverage Δ
crates/wasmi/src/engine/executor.rs 95.07% <90.00%> (-0.02%) ⬇️
crates/wasmi/src/engine/cache.rs 82.45% <90.47%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop marked this pull request as draft February 26, 2023 09:51
@Robbepop
Copy link
Member Author

Subsumed by #694. Closed.

@Robbepop Robbepop closed this Feb 27, 2023
@Robbepop Robbepop deleted the rf-opt-mem-cache branch March 11, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants