Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended-const Wasm proposal support #707

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Mar 12, 2023

Closes #638.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Mar 12, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.52ms 1.51ms ⚪ -0.07% 1.30ms 1.32ms 🔴 1.34% 🟢 -13%
execute/
bare_call_0/typed
1.13ms 1.14ms ⚪ -0.12% 983.92µs 972.07µs 🟢 -1.21% 🟢 -14%
execute/
bare_call_1
1.55ms 1.57ms 🔴 1.41% 1.42ms 1.42ms 🔴 0.00% 🟢 -10%
execute/
bare_call_16
2.43ms 2.56ms 🔴 4.65% 3.55ms 3.64ms 🔴 2.39% 🟢 42%
execute/
bare_call_16/typed
1.84ms 1.80ms 🟢 -2.66% 1.74ms 1.84ms 🔴 5.69% 🟢 2%
execute/
bare_call_1/typed
1.28ms 1.21ms 🟢 -6.10% 1.18ms 1.17ms ⚪ -1.36% 🟢 -3%
execute/
bare_call_4
1.72ms 1.76ms 🔴 2.13% 1.78ms 1.81ms 🟢 1.39% 🟢 3%
execute/
bare_call_4/typed
1.26ms 1.27ms ⚪ 0.81% 1.26ms 1.24ms 🟢 -1.85% 🟢 -2%
execute/
br_table
1.36ms 1.39ms 🔴 2.62% 1.43ms 1.45ms 🔴 1.21% 🟢 4%
execute/
count_until
650.23µs 650.36µs ⚪ 0.04% 1.30ms 1.29ms ⚪ -0.53% 🟡 98%
execute/
factorial_iterative
332.86µs 334.82µs ⚪ 0.91% 676.63µs 676.94µs ⚪ 0.24% 🔴 102%
execute/
factorial_recursive
585.86µs 590.27µs ⚪ 0.64% 910.21µs 950.86µs 🔴 4.47% 🟡 61%
execute/
fibonacci_iter
1.47ms 1.47ms ⚪ -0.52% 3.28ms 3.29ms ⚪ 0.11% 🔴 124%
execute/
fibonacci_rec
5.36ms 5.39ms ⚪ 0.50% 7.68ms 7.73ms ⚪ 0.67% 🟢 43%
execute/
fibonacci_tail
1.34ms 1.34ms ⚪ 0.24% 1.93ms 1.93ms ⚪ 0.00% 🟢 44%
execute/
global_bump
782.25µs 791.09µs ⚪ 1.04% 1.95ms 1.96ms ⚪ 0.33% 🔴 147%
execute/
global_const
717.37µs 718.94µs ⚪ 0.14% 1.64ms 1.65ms ⚪ 0.06% 🔴 129%
execute/
host_calls
36.04µs 35.32µs ⚪ -1.39% 48.82µs 48.21µs 🟢 -1.31% 🟢 36%
execute/
memory_fill
1.20ms 1.22ms 🔴 1.66% 2.70ms 2.71ms ⚪ 0.06% 🔴 122%
execute/
memory_sum
1.19ms 1.21ms 🔴 1.78% 2.64ms 2.66ms ⚪ 0.65% 🔴 119%
execute/
memory_vec_add
2.32ms 2.30ms ⚪ -0.99% 5.54ms 5.49ms ⚪ -0.82% 🔴 139%
execute/
recursive_is_even
1.00ms 1.05ms 🔴 4.50% 1.70ms 1.70ms ⚪ 0.22% 🟡 62%
execute/
recursive_ok
119.88µs 122.74µs 🔴 2.50% 204.85µs 192.10µs 🟢 -6.19% 🟡 57%
execute/
recursive_scan
155.22µs 157.29µs 🔴 1.38% 250.10µs 255.88µs 🔴 2.38% 🟡 63%
execute/
recursive_trap
12.43µs 12.43µs ⚪ -0.21% 19.81µs 19.92µs ⚪ 0.48% 🟡 60%
execute/
regex_redux
497.84µs 498.24µs ⚪ 0.00% 965.71µs 965.08µs ⚪ -0.17% 🟡 94%
execute/
rev_complement
455.45µs 456.19µs ⚪ 0.05% 922.62µs 923.54µs ⚪ 0.08% 🔴 102%
execute/
tiny_keccak
329.00µs 327.98µs ⚪ -0.07% 810.03µs 809.19µs ⚪ -0.15% 🔴 147%
execute/
trunc_f2i
782.25µs 775.13µs ⚪ -0.92% 1.62ms 1.62ms ⚪ -0.06% 🔴 109%
instantiate/
wasm_kernel
52.28µs 56.54µs 🔴 6.63% 57.48µs 54.51µs 🟢 -4.31% 🟢 -4%
translate/
erc1155
233.70µs 236.52µs 🔴 1.30% 428.19µs 444.56µs 🔴 3.64% 🟡 88%
translate/
erc20
114.07µs 114.26µs ⚪ 0.06% 206.45µs 213.02µs 🔴 3.39% 🟡 86%
translate/
erc721
161.37µs 162.99µs ⚪ 1.36% 303.14µs 310.32µs 🔴 2.20% 🟡 90%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.43% 0.00ns 0.00ns 🔴 3.68% 🟢 0%
translate/
wasm_kernel
4.09ms 4.08ms ⚪ -1.72% 7.90ms 8.20ms 🔴 3.93% 🔴 101%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #707 (f8032b9) into master (6dbbada) will increase coverage by 0.01%.
The diff coverage is 78.47%.

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   79.86%   79.87%   +0.01%     
==========================================
  Files         101      101              
  Lines        8436     8479      +43     
==========================================
+ Hits         6737     6773      +36     
- Misses       1699     1706       +7     
Impacted Files Coverage Δ
crates/wasmi/src/module/mod.rs 74.10% <ø> (ø)
crates/wasmi/src/module/element.rs 78.57% <60.00%> (-2.39%) ⬇️
crates/wasmi/src/engine/config.rs 74.07% <75.00%> (+0.04%) ⬆️
crates/wasmi/src/module/instantiate/mod.rs 80.00% <76.92%> (+4.35%) ⬆️
crates/wasmi/src/module/init_expr.rs 77.67% <77.47%> (+1.87%) ⬆️
crates/wasmi/src/engine/func_builder/translator.rs 88.68% <100.00%> (-0.10%) ⬇️
crates/wasmi/src/module/builder.rs 99.13% <100.00%> (ø)
crates/wasmi/src/module/data.rs 76.00% <100.00%> (-4.00%) ⬇️
crates/wasmi/src/module/global.rs 88.88% <100.00%> (ø)
crates/wasmi/src/table/element.rs 71.42% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit eb8d73f into master Mar 17, 2023
@Robbepop Robbepop deleted the rf-impl-extended-const branch March 17, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Wasm proposal: extended-const
3 participants