Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning #745

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Fix clippy warning #745

merged 1 commit into from
Jul 29, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.57ms 1.54ms ⚪ -1.94% 1.05ms 1.15ms 🔴 10.03% 🟢 -25%
execute/
bare_call_0/typed
1.12ms 1.14ms ⚪ -0.03% 666.11µs 741.33µs 🔴 11.42% 🟢 -35%
execute/
bare_call_1
1.70ms 1.63ms 🟢 -4.42% 1.18ms 1.27ms 🔴 8.17% 🟢 -22%
execute/
bare_call_16
2.61ms 2.58ms ⚪ -0.77% 3.51ms 3.52ms 🔴 0.30% 🟢 36%
execute/
bare_call_16/typed
1.59ms 1.61ms ⚪ 1.61% 1.77ms 1.88ms 🔴 6.28% 🟢 17%
execute/
bare_call_1/typed
1.28ms 1.28ms ⚪ 0.45% 970.30µs 1.10ms 🔴 12.98% 🟢 -14%
execute/
bare_call_4
1.78ms 1.83ms 🟢 2.15% 1.64ms 1.69ms 🔴 2.89% 🟢 -8%
execute/
bare_call_4/typed
1.28ms 1.24ms 🟢 -3.30% 950.61µs 1.00ms 🔴 5.46% 🟢 -19%
execute/
br_table
1.44ms 1.37ms 🟢 -4.91% 1.18ms 1.30ms 🔴 10.25% 🟢 -5%
execute/
count_until
635.97µs 635.98µs ⚪ 0.03% 1.35ms 1.35ms ⚪ 0.08% 🔴 112%
execute/
factorial_iterative
327.98µs 324.66µs ⚪ -1.73% 671.65µs 674.98µs ⚪ 0.58% 🔴 108%
execute/
factorial_recursive
535.40µs 530.65µs ⚪ -0.93% 959.14µs 955.15µs ⚪ -0.38% 🟡 80%
execute/
fibonacci_iter
1.44ms 1.42ms 🟢 -2.21% 3.23ms 3.24ms ⚪ 0.25% 🔴 129%
execute/
fibonacci_rec
4.46ms 4.25ms 🟢 -4.25% 7.79ms 8.23ms 🔴 5.73% 🟡 94%
execute/
fibonacci_tail
1.00ms 991.56µs ⚪ -0.90% 1.91ms 1.89ms ⚪ -0.87% 🟡 91%
execute/
global_bump
775.16µs 761.88µs ⚪ -2.00% 1.72ms 1.72ms ⚪ -0.17% 🔴 125%
execute/
global_const
685.60µs 675.94µs ⚪ -0.82% 1.68ms 1.67ms ⚪ -0.07% 🔴 148%
execute/
host_calls
38.06µs 37.50µs ⚪ -0.59% 39.23µs 39.14µs ⚪ -0.25% 🟢 4%
execute/
memory_fill
1.16ms 1.15ms ⚪ -0.51% 2.62ms 2.62ms ⚪ 0.09% 🔴 127%
execute/
memory_sum
1.16ms 1.14ms ⚪ -1.38% 2.49ms 2.49ms ⚪ -0.07% 🔴 118%
execute/
memory_vec_add
2.40ms 2.40ms ⚪ 2.16% 5.24ms 5.24ms ⚪ 0.14% 🔴 119%
execute/
recursive_is_even
758.73µs 714.31µs 🟢 -5.24% 1.36ms 1.34ms 🟢 -1.57% 🟡 87%
execute/
recursive_ok
107.85µs 103.41µs 🟢 -3.95% 189.33µs 190.49µs ⚪ 0.60% 🟡 84%
execute/
recursive_scan
147.00µs 144.53µs ⚪ -0.44% 239.03µs 239.86µs ⚪ 0.32% 🟡 66%
execute/
recursive_trap
10.62µs 10.22µs 🟢 -3.55% 19.22µs 19.34µs ⚪ 0.69% 🟡 89%
execute/
regex_redux
484.45µs 464.83µs 🟢 -3.89% 926.76µs 928.30µs ⚪ 0.16% 🟡 100%
execute/
rev_complement
423.45µs 433.29µs 🔴 2.33% 919.86µs 929.97µs ⚪ 1.02% 🔴 115%
execute/
tiny_keccak
325.50µs 324.48µs ⚪ -0.38% 805.96µs 837.70µs 🔴 3.70% 🔴 158%
execute/
trunc_f2i
756.15µs 753.60µs ⚪ 1.23% 1.78ms 1.77ms ⚪ -0.12% 🔴 135%
instantiate/
wasm_kernel
57.37µs 62.26µs 🔴 8.19% 57.01µs 59.58µs 🔴 4.69% 🟢 -4%
translate/
erc1155
191.97µs 189.27µs ⚪ -1.50% 319.33µs 314.12µs 🟢 -1.72% 🟡 66%
translate/
erc20
97.45µs 93.05µs 🟢 -4.45% 154.57µs 153.12µs ⚪ -1.25% 🟡 65%
translate/
erc721
137.68µs 130.60µs 🟢 -5.19% 222.21µs 219.37µs 🟢 -1.21% 🟡 68%
translate/
spidermonkey
59.37ms 57.86ms 🟢 -2.77% 0.00ns 0.00ns 🟢 -1.33% 🟢 -100%
translate/
wasm_kernel
4.06ms 4.06ms ⚪ -0.43% 5.83ms 5.81ms ⚪ -0.43% 🟢 43%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #745 (eae310f) into master (e5fdb7f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #745   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files         104      104           
  Lines        9054     9054           
=======================================
  Hits         7189     7189           
  Misses       1865     1865           
Files Changed Coverage Δ
crates/wasmi/src/module/instantiate/mod.rs 79.74% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit fbe1810 into master Jul 29, 2023
17 checks passed
@Robbepop Robbepop deleted the rf-fix-clippy-warning branch July 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants