Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work for Thermal Foundation and Redstone Arsenal bows #2

Closed
caanthedalek opened this issue Apr 10, 2018 · 3 comments
Closed

Comments

@caanthedalek
Copy link

As the title says, all 'reinforced' bows from Thermal Foundation and the flux-infused bow from Redstone Arsenal behave as they would without the mod. Tested with bows from EnderIO, Natura, and Botania, and only Thermal/Arsenal bows appear to be affected. Using bow infinity fix rv5 on Minecraft 1.12 in a modified version of the FTB Revelation pack via the Twitch (formerly Curse) launcher. Thanks for the mod!

@Parker8283
Copy link
Owner

Parker8283 commented Apr 11, 2018

That's on the mod authors to handle. The way this mod works is modifying the Minecraft ItemBow class to short-circuit before the check for ammo if Infinity is on the bow. Adding that fix in the same way to other mods would cause mod developers to be unhappy with me. Other mods that already work are not because of this mod, but because they added that code themselves.

So, TL;DR: Ask for it to be a feature in the CoFH Feedback center.

@caanthedalek
Copy link
Author

Cool, thanks for the quick reply.

@Parker8283
Copy link
Owner

Over a year later, and I found a way to easily support modded bows!
If you're running rv5.1/rv6 or later, all modded bows should be supported. If they aren't, it's still on the mod author, but all they have to do is post an ArrowNockEvent. So if you find a modded bow that doesn't work, just tell them to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants