Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework plugin loading and building #29

Closed
parklez opened this issue Apr 7, 2021 · 1 comment
Closed

Rework plugin loading and building #29

parklez opened this issue Apr 7, 2021 · 1 comment
Assignees
@parklez
Labels
enhancement New feature or request

Comments

@parklez
Copy link
Owner

parklez commented Apr 7, 2021

Currently, all plugins are loaded in app.py, that was a decision because pyinstaller wasn't hooking external dependencies correctly at some point in time(?). Plugins are also loaded from 2 different locations, which is confusing.
My proposed change is to move the plugins folder to the root of the project.
During the build, pyinstaller now needs to hook "hidden imports".
@parklez parklez added the enhancement New feature or request label Apr 7, 2021
@parklez parklez self-assigned this Apr 7, 2021
@parklez
Copy link
Owner Author

parklez commented Apr 7, 2021

4a631b2 and 944ed4d

@parklez parklez closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parklez parklez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parklez