Last changes including significant aesthetic changes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: wildlifelicensing/apps/applications/templates/wl/entry/select_licence_type.html wildlifelicensing/static/wl/css/base.css
Conflicts: wildlifelicensing/apps/applications/templates/wl/entry/select_licence_type.html wildlifelicensing/static/wl/css/base.css Also updated look of banner and added banner to returns.
….css to applications.css
Conflicts: wildlifelicensing/apps/returns/templates/wl/enter_return.html Changed text on customer dashboard and select licence type pages.
…Edge. This feature was turning application/licence number into phone number (link).
…ndows Added meta header to turn off the telephone number detection for W11/…
Changed product code from slug-field to charfield
Put in mixins for amend / renew licences Moved extracted application field inputs to top of issue licence form Credid card payment only processed when issue licence form is valid. Temporary applications are removed in dashboard view. Fixed licence expired status (wasn't showing before) Added (Nil) suffix to status for submitted nil returns. Reinstated status in officer's licence table. Fixed actions in officer's licence table for when can't amend/renew/reissue. Removed current/future returns for previous licence when issuing amended licence. Can now properly curate Nil returns.
Aesthetic changes and bug fixes
|
Reviewed 1 of 34 files at r1, 1 of 33 files at r3, 1 of 36 files at r5, 42 of 47 files at r7, 5 of 5 files at r8. Comments from Reviewable |
dbca-asi
pushed a commit
that referenced
this pull request
Mar 1, 2017
Changes to licence status for when it's renewed/amended.
dbca-asi
pushed a commit
that referenced
this pull request
Mar 25, 2019
Wildlifecompliance merge latest from dbca-dragon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aesthetic changes
Bug Fixes / Other changes
amend/renew/reissue.
licence.
Added a couple of tests for testing the authorization of some views.
Changed product code from slug-field to charfield
This change is