Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger: Fix for the oracle import #249

Merged
merged 6 commits into from
Nov 29, 2017
Merged

Conversation

rayrayndwiga
Copy link
Contributor

@rayrayndwiga rayrayndwiga commented Nov 29, 2017

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.01%) to 48.541% when pulling dcd309f on rayrayndwiga:master into 218eedc on parksandwildlife:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.09%) to 48.467% when pulling bef39ae on rayrayndwiga:master into 218eedc on parksandwildlife:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.09%) to 48.467% when pulling a3d0019 on rayrayndwiga:master into 218eedc on parksandwildlife:master.

@scottp-dpaw
Copy link

ledger/payments/reports.py, line 362 at r3 (raw file):

    # Get all transactions
    cash = CashTransaction.objects.filter(created__gte=start, created__lte=end,district=district).order_by('-created')

the replacement filters don't seem to check for system like before (e.g. invoice__system=system)?


Comments from Reviewable

@scottp-dpaw
Copy link

Reviewed 2 of 2 files at r1, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dbca-asi dbca-asi merged commit 870b738 into dbca-wa:master Nov 29, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 48.474% when pulling 0808059 on rayrayndwiga:master into 218eedc on parksandwildlife:master.

@scottp-dpaw
Copy link

:lgtm:


Comments from Reviewable

dbca-asi pushed a commit that referenced this pull request Aug 6, 2019
Merge latest from dbca-wa master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants