Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate setting of backstage.global.clusterRouterBase #12

Closed
dmartinol opened this issue Dec 20, 2023 · 4 comments · Fixed by #36
Closed

Automate setting of backstage.global.clusterRouterBase #12

dmartinol opened this issue Dec 20, 2023 · 4 comments · Fixed by #36

Comments

@dmartinol
Copy link
Contributor

Can we replace the manual setting of backstage.global.clusterRouterBase with a lookup function?

oc get ingress.config.openshift.io/cluster -oyaml | yq '.spec.domain'

The lookup should be like:

{{- $cluster := lookup "config.openshift.io/v1" "Ingress" ".Values.global.rhsso.namespace" "cluster" }}
{{- $domain := "UNKNOWN" }}
{{- if hasKey $cluster "spec" }}
  {{- if hasKey $cluster.spec "domain" }}
    {{- $domain = $cluster.spec.domain}}
  {{- end }}
{{- end }}
@dmartinol
Copy link
Contributor Author

@masayag

@masayag
Copy link
Contributor

masayag commented Dec 26, 2023

@dmartinol
Copy link
Contributor Author

I missed the fact that this is used in a dependant chart, and helm does not provide a way to override a template function.
so, assuming that Backstage deployers are already familiar with using this global flag, we can probably just accept this as is (or maybe create ab equivalent issue in the upstream project, so they can solve it instead)

@dmartinol
Copy link
Contributor Author

Tracked new issue janus-idp/helm-backstage#167 to dependant chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants