Hackney Converter: Options sanitization fails

[eniolopes]

When doing a request using hackney I get the following error:

** (FunctionClauseError) no function clause matching in anonymous fn/1 in ExVCR.Adapter.Hackney.Converter.sanitize_options/1
     stacktrace:
       lib/exvcr/adapter/hackney/converter.ex:35: anonymous fn(:with_body) in ExVCR.Adapter.Hackney.Converter.sanitize_options/1
       (elixir) lib/enum.ex:1184: Enum."-map/2-lists^map/1-0-"/2
       lib/exvcr/adapter/hackney/converter.ex:29: ExVCR.Adapter.Hackney.Converter.request_to_string/1
       lib/exvcr/adapter/hackney/converter.ex:6: ExVCR.Adapter.Hackney.Converter.convert_to_string/2
       lib/exvcr/handler.ex:137: ExVCR.Handler.get_response_from_server/2
       (hackney) :hackney.request(:get, "...", [...], "", [:with_body, {:max_body, 30000000}])

Error is happening because the function sanitize_options/1, here, is expecting a list of tuples, but hackney also accepts single atoms as values.

[parroty]

Thanks for the report. Is it possible for you to post an example request? (which corresponds to your error).

Also, I'm looking around the hackney spec and it seems to be noted as list.
https://github.com/benoitc/hackney/blob/master/doc/hackney.md#request5

[digaoddc]

@parroty
It is happening with POST requests and hackney .
If you write a test in ExVCR.Adapter.HackneyTest, with the following request, it will probably fail .

:hackney.request(:post, "https://mydomain.com", [], "{}", [:insecure] )