New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show_just_path_prediction #70
Comments
Looks pretty cool! I think our goal, though, is to show the path from root to predictor leaf in a big tree as tightly as possible. I wonder what it looks like as a vertical stack of just the decision nodes entered and then the leaf. That would be the smallest footprint, which I think is kind of the goal here. what do you think? |
Indeed, if I look again at above visualisation, it looks 'scattered'. I will adjust it to the vertical stack version. Let's see how it'll look ;) |
heh, nice work! I like it. Does it work horizontally too? I think we have an option for that. |
cool. By horizontally.... do you mean a horizontal stack instead of vertical stack ? |
yep, left to right |
wouldn't be a problem if the prediction path is very deep ? I think we will end with a 'crowdy' plot. |
well, sometimes you want very tall and sometimes very wide. seems like original code can change orientation so this should inherit that; i assume you just cut/paste, right? |
I wanted to use as much functionality as possible from dtreeviz(), so I didn't cut/paste. I will take a look for horizontal view. There is little work left also for vertical view, I made a little 'hack' to create the visualisation with vertical view for decision nodes only :) |
We can skip horizontal if it gets messy in the code :) |
Looks great! Only question is, how do we activate this? Seems like it should be an arg to existing tree viz functions. Oh, I see you have |
I didn't try it on regression trees. I will try it tomorrow. |
great job! |
I started to work on showing just the prediction path (based on what we discussed in a previous issue)
Right now, it looks like this :
Am I on the right track ? :) Do you think we need to show also the neighborhood nodes. I don't have a strong argument for them, but I like how they look (they show somehow the 'opposite' prediction path)
The text was updated successfully, but these errors were encountered: