feat: add support for custom objectId #1088

martinpfannemueller · 2021-04-12T10:31:52Z

I implemented the custom objectId feature mentioned in #1087 including unit tests. Is there something missing to get this merged?

Thanks!

azlekov

@martinpfannemueller I have reviewed your code and looks quite clean and nice to me. Can you merge master here in your branch and check the small feedback I left.

Thanks

parse/src/main/java/com/parse/ParseRESTObjectCommand.java

parse/src/test/java/com/parse/ParseObjectTest.java

mtrezza · 2021-10-11T10:45:52Z

Looking at the changes, should we add a lint step to the CI?

azlekov · 2021-10-11T15:16:18Z

Please open an issue @mtrezza I can take it

mtrezza · 2021-10-11T15:50:45Z

Great, there it is! #1119

…-Android into feature/custom_objectId # Conflicts: # parse/src/test/java/com/parse/ParseClientConfigurationTest.java # parse/src/test/java/com/parse/ParseObjectTest.java

parse-github-assistant · 2021-10-11T18:00:10Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2021-10-11T18:00:13Z

Thanks for opening this pull request!

❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

martinpfannemueller · 2021-10-11T18:57:56Z

I have no idea why the two tests testObjectNotFoundWhenSaveAsync and testMissingRequiredFieldWhenSaveAsync in the ParseInstallationTest-file fail here. Locally everything runs just fine. Attached you will find the output of running the task jacocoTestReport locally.
jacocoTestReport.log

azlekov · 2021-10-11T20:25:47Z

@martinpfannemueller can you close and re-open the PR so we can trigger another CI

azlekov · 2021-10-14T08:07:56Z

@mtrezza how we can re-run the CI build. I tried already closing and re-opening the issue.

mtrezza · 2021-10-14T18:22:16Z

I suggest to first resolve the conflicts, then we look into the CI.

## [2.0.1](parse-community/Parse-SDK-Android@2.0.0...2.0.1) (2021-10-14) ### Bug Fixes * add maven publications to configure the Jitpack releases ([parse-community#1128](parse-community#1128)) ([67c4fb6](parse-community@67c4fb6))

## [2.0.1](mtrezza/Parse-SDK-Android@2.0.0...2.0.1) (2021-10-14) ### Bug Fixes * add maven publications to configure the Jitpack releases ([parse-community#1128](https://github.com/mtrezza/Parse-SDK-Android/issues/1128)) ([67c4fb6](mtrezza@67c4fb6))

…-Android into feature/custom_objectId # Conflicts: # parse/src/main/java/com/parse/ParseRESTObjectCommand.java # parse/src/test/java/com/parse/ParseObjectTest.java

…-Android into feature/custom_objectId

martinpfannemueller · 2021-10-27T18:06:43Z

I added an explicit test for the ParseRESTCommand and the logic of it. The test coverage should be fine now.

mtrezza · 2021-10-27T20:31:36Z

Running tests...

azlekov

@mtrezza @martinpfannemueller LGTM

mtrezza

Could you please also add doc headers to the new public properties and methods? So that this feature appears in the API documentation.

azlekov · 2021-11-16T07:45:13Z

@martinpfannemueller gentle ping when you have some free time if is possible to add some JavaDoc as @mtrezza pleases, so this can be merged. Looking forward to see this merged 🤞

…-Android into feature/custom_objectId

martinpfannemueller · 2021-11-21T10:15:01Z

I just added some JavaDoc to allowCustomObjectId() in the configuration builder and the isAllowCustomObjectId() getter.

parse/src/main/java/com/parse/Parse.java

mtrezza · 2021-11-21T13:48:40Z

There also seems to be a lint fix needed, see the failing lint check

martinpfannemueller · 2021-11-21T15:30:06Z

I updated the JavaDoc and ran spotlessApply

mtrezza · 2021-11-21T16:12:02Z

Thanks, let just see whether the CI passes.

mtrezza

Looks good, thanks for this PR!

# [2.1.0](2.0.6...2.1.0) (2021-11-21) ### Features * add support for custom objectId ([#1088](#1088)) ([d420371](d420371))

parseplatformorg · 2021-11-21T16:17:18Z

🎉 This change has been released in version 2.1.0

Martin Pfannemüller added 9 commits April 12, 2021 12:21

Add option allowCustomObjectId

419bba1

Use POST request in case objectId is set and allowCustomObjectId is true

1866c16

Exclude ParseInstallation when saving

444fca0

Check for objectId when allowCustomObjectId is true

aa08665

Check for new object for selecting POST request

7d86008

Use correct error code

c72fbbb

Same logic as in JS SDK for deciding about HTTP request

5688270

Fix comparison

c5f1eee

Add unit tests for custom objectId

b268f38

azlekov suggested changes Oct 10, 2021

View reviewed changes

Martin Pfannemüller added 3 commits October 11, 2021 19:39

Format code and add missing assertion to test

2948b8c

Merge branch 'master' of https://github.com/parse-community/Parse-SDK…

f308e10

…-Android into feature/custom_objectId # Conflicts: # parse/src/test/java/com/parse/ParseClientConfigurationTest.java # parse/src/test/java/com/parse/ParseObjectTest.java

Fixes corresponding to changes in version 2.0.0

bad7297

martinpfannemueller changed the title ~~Support for custom objectId, implements #1087~~ feat: Support for custom objectId, implements #1087 Oct 11, 2021

parse-github-assistant bot changed the title ~~feat: Support for custom objectId, implements #1087~~ feat: support for custom objectId, implements #1087 Oct 11, 2021

azlekov closed this Oct 14, 2021

azlekov reopened this Oct 14, 2021

semantic-release-bot and others added 4 commits October 14, 2021 18:55

chore(release): 2.0.1 [skip ci]

0d54b49

## [2.0.1](parse-community/Parse-SDK-Android@2.0.0...2.0.1) (2021-10-14) ### Bug Fixes * add maven publications to configure the Jitpack releases ([parse-community#1128](parse-community#1128)) ([67c4fb6](parse-community@67c4fb6))

docs: remove 2.0.1 release entry

a091eb1

Merge branch 'master' of https://github.com/parse-community/Parse-SDK…

f8bca7c

…-Android into feature/custom_objectId # Conflicts: # parse/src/main/java/com/parse/ParseRESTObjectCommand.java # parse/src/test/java/com/parse/ParseObjectTest.java

Martin Pfannemüller added 6 commits October 25, 2021 19:28

Use setter method for setting allowCustomObjectId

fa5a0fb

Add missing ;

8e00af8

Fix typo in test name

c444e6b

Add test for saveObjectCommand

ae9d016

Run spotlessApply

f9f4519

Merge branch 'master' of https://github.com/parse-community/Parse-SDK…

46531f1

…-Android into feature/custom_objectId

azlekov approved these changes Nov 3, 2021

View reviewed changes

Merge branch 'master' into feature/custom_objectId

408acba

mtrezza changed the title ~~feat: support for custom objectId, implements #1087~~ feat: support for custom objectId Nov 3, 2021

mtrezza changed the title ~~feat: support for custom objectId~~ feat: add support for custom objectId Nov 3, 2021

mtrezza requested changes Nov 3, 2021

View reviewed changes

azlekov mentioned this pull request Nov 16, 2021

The future of Parse Android SDK #1100

Open

13 tasks

Martin Pfannemüller added 3 commits November 21, 2021 11:03

Add JavaDoc for allowCustomObjectId method

9e70f7f

Merge branch 'master' of https://github.com/parse-community/Parse-SDK…

bd50d60

…-Android into feature/custom_objectId

Add JavaDoc to isAllowCustomObjectId()

8130153

mtrezza reviewed Nov 21, 2021

View reviewed changes

parse/src/main/java/com/parse/Parse.java Outdated Show resolved Hide resolved

Martin Pfannemüller added 2 commits November 21, 2021 16:28

Update documentation

a106246

Run spotlessApply

461a8db

mtrezza approved these changes Nov 21, 2021

View reviewed changes

mtrezza merged commit d420371 into parse-community:master Nov 21, 2021

parseplatformorg pushed a commit that referenced this pull request Nov 21, 2021

chore(release): 2.1.0 [skip ci]

b065eff

# [2.1.0](2.0.6...2.1.0) (2021-11-21) ### Features * add support for custom objectId ([#1088](#1088)) ([d420371](d420371))

parseplatformorg added the state:released Released as stable version label Nov 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for custom objectId #1088

feat: add support for custom objectId #1088

martinpfannemueller commented Apr 12, 2021

azlekov left a comment

mtrezza commented Oct 11, 2021

azlekov commented Oct 11, 2021

mtrezza commented Oct 11, 2021

parse-github-assistant bot commented Oct 11, 2021

parse-github-assistant bot commented Oct 11, 2021 •

edited

martinpfannemueller commented Oct 11, 2021

azlekov commented Oct 11, 2021

azlekov commented Oct 14, 2021

mtrezza commented Oct 14, 2021

martinpfannemueller commented Oct 27, 2021

mtrezza commented Oct 27, 2021

azlekov left a comment

mtrezza left a comment •

edited

azlekov commented Nov 16, 2021

martinpfannemueller commented Nov 21, 2021

mtrezza commented Nov 21, 2021 •

edited

martinpfannemueller commented Nov 21, 2021

mtrezza commented Nov 21, 2021

mtrezza left a comment •

edited

parseplatformorg commented Nov 21, 2021

feat: add support for custom objectId #1088

feat: add support for custom objectId #1088

Conversation

martinpfannemueller commented Apr 12, 2021

azlekov left a comment

Choose a reason for hiding this comment

mtrezza commented Oct 11, 2021

azlekov commented Oct 11, 2021

mtrezza commented Oct 11, 2021

parse-github-assistant bot commented Oct 11, 2021

parse-github-assistant bot commented Oct 11, 2021 • edited

Thanks for opening this pull request!

martinpfannemueller commented Oct 11, 2021

azlekov commented Oct 11, 2021

azlekov commented Oct 14, 2021

mtrezza commented Oct 14, 2021

martinpfannemueller commented Oct 27, 2021

mtrezza commented Oct 27, 2021

azlekov left a comment

Choose a reason for hiding this comment

mtrezza left a comment • edited

Choose a reason for hiding this comment

azlekov commented Nov 16, 2021

martinpfannemueller commented Nov 21, 2021

mtrezza commented Nov 21, 2021 • edited

martinpfannemueller commented Nov 21, 2021

mtrezza commented Nov 21, 2021

mtrezza left a comment • edited

Choose a reason for hiding this comment

parseplatformorg commented Nov 21, 2021

parse-github-assistant bot commented Oct 11, 2021 •

edited

mtrezza left a comment •

edited

mtrezza commented Nov 21, 2021 •

edited

mtrezza left a comment •

edited