feat: update various dependencies #1172

rommansabbir · 2022-06-03T17:04:12Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Related issue: #1163

Approach

According to #1163 (comment):

Set upper range for FB Login SDK to >=13.1.0 <14.0.0 in this PR
Merge this PR with a major version increase, as it may be a breaking change. The FB Login SDK is currently added as api, so it can transitively accessed if the developer adds the Parse SDK also as api to their app. Since the FB SDK has some braking changes with 13.x, we need to consider that also a breaking change for the Parse SDK.

TODOs before merging

Add tests
Add changes to documentation (guides, repository pages, in-code descriptions)
A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

…n update.

parse-github-assistant · 2022-06-03T17:04:21Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

rommansabbir · 2022-06-03T17:21:51Z

@mtrezza CI is failing.

com.parse.ParseCorePluginsTest > testQueryControllerDefaultImpl FAILED
    java.lang.AssertionError at ParseCorePluginsTest.java:36
[Tests passed: 14 of 14 tests - my local machine - CI Fail]

com.parse.ParseDecoderTest > testCompleteness FAILED
    java.lang.AssertionError at ParseDecoderTest.java:270
[Tests passed: 23 of 23 tests - my local machine - CI Fail]

com.parse.ParseDecoderTest > testCompletenessOfIncludedParseObject FAILED
    java.lang.AssertionError at ParseDecoderTest.java:294
[Tests passed: 23 of 23 tests -  local machine - CI Fail]

Any idea on this failing?

mtrezza · 2022-06-03T17:44:37Z

Does it pass locally? If so, it may be the java version or another env version maybe.

rommansabbir · 2022-06-04T07:51:19Z

Does it pass locally? If so, it may be the java version or another env version maybe.

@mtrezza @mman any idea on how to access this file file:///home/runner/work/Parse-SDK-Android/Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html, so that I can check the stacktrace.

I ran gradle clean testDebugUnitTest command and checked the test reports. 3 test cases failing on both CI, Local but when testing through Run no errors at all.

Tried to findout the root cause but failed.

Any idea how to fix this?

mtrezza · 2022-06-04T09:30:03Z

If you want to inspect that in the CI, you would have to modify the workflow file and output the file in the console. But since you can reproduce this locally, that may not be necessary. Why can't you access Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html locally? Is there no file?

rommansabbir · 2022-06-04T10:13:14Z

If you want to inspect that in the CI, you would have to modify the workflow file and output the file in the console. But since you can reproduce this locally, that may not be necessary. Why can't you access Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html locally? Is there no file?

Actually I did founds those issues and solved too but when tested by "Run" it doesn’t work but working fine in gradle clean testDebugUnitTest.

Need more time to investigate the issues, it would be more helpful if you or @mman could look at the issue too alongside with me.

rommansabbir · 2022-06-04T12:55:51Z

@mtrezza The issues arise when we are performing a gradle clean testDebugUnitTest, which remove the buildDir folder.
So there is a possibilites that some of the component's build files get removed duing the clean operations, as all of the components is inter-connected to each others.

Here is the stacktraces for all failed tests.

ParseCorePluginsTest

testQueryControllerDefaultImpl

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at com.parse.ParseCorePluginsTest.testQueryControllerDefaultImpl(ParseCorePluginsTest.java:37)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

ParseDecoderTest

testCompleteness

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
	at com.parse.ParseDecoderTest.testCompleteness(ParseDecoderTest.java:270)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

testCompletenessOfIncludedParseObject

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
	at com.parse.ParseDecoderTest.testCompletenessOfIncludedParseObject(ParseDecoderTest.java:294)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

mtrezza · 2022-06-04T14:37:13Z

It could also be helpful to go back and see with which commit this issue started to occur. If I recall correctly, we had all tests passing not so long ago.

rommansabbir · 2022-06-04T16:03:26Z

Okay. I will go through the commit changes.

rommansabbir · 2022-06-07T14:56:39Z

AGPBI: {"kind":"warning","text":"Software Components will not be created automatically for Maven publishing from Android Gradle Plugin 8.0. To opt-in to the future behavior, set the Gradle property android.disableAutomaticComponentCreation=true in the gradle.properties file or use the new publishing DSL.","sources":[{}]}

@mtrezza

…pdated, Junit-Jupiter dependency added, new Test task added to use JUnit Platform

codecov · 2022-06-07T15:04:22Z

Codecov Report

Merging #1172 (dab2045) into master (ec7bd03) will decrease coverage by 67.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #1172       +/-   ##
============================================
- Coverage     67.31%   0.00%   -67.32%     
============================================
  Files           122     122               
  Lines          9962    9962               
  Branches       1343    1343               
============================================
- Hits           6706       0     -6706     
- Misses         2735    9962     +7227     
+ Partials        521       0      -521

Impacted Files	Coverage Δ
parse/src/main/java/com/parse/ParseRole.java	`0.00% <0.00%> (-100.00%)`	⬇️
parse/src/main/java/com/parse/ParseCloud.java	`0.00% <0.00%> (-100.00%)`	⬇️
parse/src/main/java/com/parse/ParseException.java	`0.00% <0.00%> (-100.00%)`	⬇️
parse/src/main/java/com/parse/ParseTextUtils.java	`0.00% <0.00%> (-100.00%)`	⬇️
parse/src/main/java/com/parse/PointerEncoder.java	`0.00% <0.00%> (-100.00%)`	⬇️
parse/src/main/java/com/parse/ParseDateFormat.java	`0.00% <0.00%> (-100.00%)`	⬇️
...rse/src/main/java/com/parse/ParseFileHttpBody.java	`0.00% <0.00%> (-100.00%)`	⬇️
...rse/src/main/java/com/parse/ParseSetOperation.java	`0.00% <0.00%> (-100.00%)`	⬇️
...se/src/main/java/com/parse/OfflineObjectStore.java	`0.00% <0.00%> (-100.00%)`	⬇️
...se/src/main/java/com/parse/http/ParseHttpBody.java	`0.00% <0.00%> (-100.00%)`	⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c658995...dab2045. Read the comment docs.

rommansabbir · 2022-06-07T15:14:51Z

@mtrezza can you take a look at the codecov/project — 0.00% (target 65.00%) fail?

mtrezza · 2022-06-07T21:24:31Z

The codecov seems to be a temporary issue:

Github API rate limit error: Forbidden Check on Codecov's status

Not sure whether we (Parse Platform) are hitting the API limit, or GitHub in general. We'll ignore this check for merge in this PR.

I see all other checks pass! That's amazing, so did you find what made it fail previously? This?

rommansabbir · 2022-06-08T02:02:04Z

I see all other checks pass! That's amazing, so did you find what made it fail previously? This?

I tried a lot of solutions but ended up with dependency issue solving. testImplementation of JUnit Jupiter & Test Task to support jUnitPlatform, that's it. Easy fix but took time 😅

mtrezza · 2022-06-08T09:45:14Z

A PR can only address and describe a single issue, so we need to consolidate the PR title.

I suggest:

feat: update various dependencies

BREAKING CHANGE: The Facebook Login SDK is upgraded to 13.x; this is a transitive dependency, so if you are directly calling the Facebook Login SDK in your app then this may be a braking change; this release of the Parse Android SDK adds a version range to the Facebook Login SDK dependency for correct gradle dependency resolving

mtrezza

Look good, great work @rommansabbir! Let's get just another review before merge.

rommansabbir · 2022-06-09T09:10:42Z

Any update on the review @parse-community/android-sdk-review?

azlekov

What was the idea behind adding jupiter?

I remember that Android is compatible with junit but not jupiter. If that's not the case, may I ask for a reference? And why having both, the tests should be using either one of them...

rommansabbir · 2022-06-09T13:37:08Z

What was the idea behind adding jupiter?

It was required to execute gradle task.

I remember that Android is compatible with junit but not jupiter

In short, I went though the commits to find out which commit cause the test cases failure. But didn't found any suspicious commits. So I started focus on the dependencies, as many of the were updated to latest version.

Then in DEBUG mode, I found some of the classes were not found during the test which might causes the Illegal Access. One of them was Boolean class. So it was confirmed that test cases were failing becuase of those mentioned classes was not found.

So, I added tasks.withType(Test) {useJUnitPlatform()} since we are using Gradle 7.x. But now Gradle Task can't execute without Jupiter dependency. After adding those, test's passes without any issue, as we expected.

azlekov · 2022-06-09T15:28:50Z

@rommansabbir do you think we can migrate then to jupiter instead using junit. It's preferable to use only one library, where junit and jupiter are almost same, different versions.

rommansabbir · 2022-06-09T15:42:40Z

@rommansabbir do you think we can migrate then to jupiter instead using junit. It's preferable to use only one library, where junit and jupiter are almost same, different versions.

I think we can keep this as it is (If no issue arise). In future we have to migrate to JUnit 5.x and Jupiter is required for that.

So, we have to decide, what we want.

mtrezza · 2022-06-09T20:10:22Z

@L3K0V What do you think about merging as is with both jupiter and junit? Any concerns? I understand that we should decide on a single one, but are there also any possible (technical) side effects if we merge both?

azlekov · 2022-06-10T06:04:29Z

@mtrezza, I think we can proceed merging as it is.

mtrezza · 2022-06-10T11:09:07Z

Nice job everyone and thanks for reviving this PR @rommansabbir!

# [4.0.0](3.0.1...4.0.0) (2022-06-10) ### Features * update various dependencies ([#1172](#1172)) ([779dc0b](779dc0b)) ### BREAKING CHANGES * The Facebook Login SDK is upgraded to 13.x; this is a transitive dependency, so if you are directly calling the Facebook Login SDK in your app then this may be a braking change; this release of the Parse Android SDK adds a version range to the Facebook Login SDK dependency for correct gradle dependency resolving ([779dc0b](779dc0b))

parseplatformorg · 2022-06-10T11:09:45Z

🎉 This change has been released in version 4.0.0

mobilekosmos and others added 11 commits April 16, 2022 09:08

parse-community#1159 fixed

ef14e13

parse-community#1159 fixed

c2e5a77

parse-community#1159 fixed

e87101f

Mockito imports updated according to changes in mockito 4.

2b97aa7

Code formatting with spotless.

9886ccb

Fixed org.mockito.Matchers not available anymore after mockito versio…

635c38e

…n update.

Code formatting with spotless.

ca23cd7

Merge branch 'master' into master

cb349b8

Merge branch 'master' into master

b01922d

Merge branch 'master' into master

767da96

fix: FB SDK (api) version set to a specific range (parse-community#1163)

d55fa89

mtrezza mentioned this pull request Jun 3, 2022

feat: update gradle dependencies #1163

Closed

5 tasks

This was linked to issues Jun 3, 2022

Facebook login fails logging in to Facebook from an embedded browser #1164

Closed

Gradle dependencies out of date #1159

Closed

rommansabbir force-pushed the fix/fb branch 2 times, most recently from 97a11fe to d55fa89 Compare June 4, 2022 07:43

ci failing : fixed issue (parse-community#1172), dependency version u…

dab2045

…pdated, Junit-Jupiter dependency added, new Test task added to use JUnit Platform

rommansabbir requested a review from mtrezza June 8, 2022 04:39

mtrezza approved these changes Jun 8, 2022

View reviewed changes

mtrezza requested a review from a team June 8, 2022 09:59

mtrezza changed the title ~~fix: fb login fail from embedded browser (FB SDK), feat: update gradle dependencies~~ feat: update various dependencies; add Facebook Login SDK dependency version range for correct gradle dependency resolving Jun 8, 2022

mtrezza changed the title ~~feat: update various dependencies; add Facebook Login SDK dependency version range for correct gradle dependency resolving~~ feat: update various dependencies Jun 8, 2022

azlekov approved these changes Jun 9, 2022

View reviewed changes

mtrezza merged commit 779dc0b into parse-community:master Jun 10, 2022

parseplatformorg added the state:released Released as stable version label Jun 10, 2022

rommansabbir deleted the fix/fb branch June 10, 2022 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update various dependencies #1172

feat: update various dependencies #1172

rommansabbir commented Jun 3, 2022 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jun 3, 2022 •

edited

Loading

rommansabbir commented Jun 3, 2022

mtrezza commented Jun 3, 2022

rommansabbir commented Jun 4, 2022 •

edited

Loading

mtrezza commented Jun 4, 2022 •

edited

Loading

rommansabbir commented Jun 4, 2022

rommansabbir commented Jun 4, 2022

mtrezza commented Jun 4, 2022 •

edited

Loading

rommansabbir commented Jun 4, 2022

rommansabbir commented Jun 7, 2022 •

edited

Loading

codecov bot commented Jun 7, 2022 •

edited

Loading

rommansabbir commented Jun 7, 2022 •

edited

Loading

mtrezza commented Jun 7, 2022 •

edited

Loading

rommansabbir commented Jun 8, 2022

mtrezza commented Jun 8, 2022 •

edited

Loading

mtrezza left a comment

rommansabbir commented Jun 9, 2022

azlekov left a comment

rommansabbir commented Jun 9, 2022

azlekov commented Jun 9, 2022

rommansabbir commented Jun 9, 2022

mtrezza commented Jun 9, 2022 •

edited

Loading

azlekov commented Jun 10, 2022

mtrezza commented Jun 10, 2022

parseplatformorg commented Jun 10, 2022

feat: update various dependencies #1172

feat: update various dependencies #1172

Conversation

rommansabbir commented Jun 3, 2022 • edited by mtrezza Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Jun 3, 2022 • edited Loading

Thanks for opening this pull request!

rommansabbir commented Jun 3, 2022

mtrezza commented Jun 3, 2022

rommansabbir commented Jun 4, 2022 • edited Loading

mtrezza commented Jun 4, 2022 • edited Loading

rommansabbir commented Jun 4, 2022

rommansabbir commented Jun 4, 2022

mtrezza commented Jun 4, 2022 • edited Loading

rommansabbir commented Jun 4, 2022

rommansabbir commented Jun 7, 2022 • edited Loading

codecov bot commented Jun 7, 2022 • edited Loading

Codecov Report

rommansabbir commented Jun 7, 2022 • edited Loading

mtrezza commented Jun 7, 2022 • edited Loading

rommansabbir commented Jun 8, 2022

mtrezza commented Jun 8, 2022 • edited Loading

mtrezza left a comment

Choose a reason for hiding this comment

rommansabbir commented Jun 9, 2022

azlekov left a comment

Choose a reason for hiding this comment

rommansabbir commented Jun 9, 2022

azlekov commented Jun 9, 2022

rommansabbir commented Jun 9, 2022

mtrezza commented Jun 9, 2022 • edited Loading

azlekov commented Jun 10, 2022

mtrezza commented Jun 10, 2022

parseplatformorg commented Jun 10, 2022

rommansabbir commented Jun 3, 2022 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jun 3, 2022 •

edited

Loading

rommansabbir commented Jun 4, 2022 •

edited

Loading

mtrezza commented Jun 4, 2022 •

edited

Loading

mtrezza commented Jun 4, 2022 •

edited

Loading

rommansabbir commented Jun 7, 2022 •

edited

Loading

codecov bot commented Jun 7, 2022 •

edited

Loading

rommansabbir commented Jun 7, 2022 •

edited

Loading

mtrezza commented Jun 7, 2022 •

edited

Loading

mtrezza commented Jun 8, 2022 •

edited

Loading

mtrezza commented Jun 9, 2022 •

edited

Loading