Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse.File.cancel starts new attempt to save file #1781

Merged
merged 14 commits into from
Mar 1, 2023
Merged

fix: Parse.File.cancel starts new attempt to save file #1781

merged 14 commits into from
Mar 1, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 17, 2023 •
edited

Pull Request

Issue

Closes: #1162

Approach

  • Properly handle npm run watch:browser compiling to the /dist directory
  • Add missing _aborted check

Viewing the Network Requests with puppeteer

Disabling headless mode to launch chromium
Showing devtools on load
userDataDir is used to store preserve logs peference in the network tab

browser = await puppeteer.launch({ args: ['--disable-web-security'], headless:false, devtools: true, userDataDir: path.resolve(__dirname, './myUserDataDir') });

To keep chromium running use setTimeout, done, Jasmine timeout. If network requests aren't showing set 5 second timeout around page.evaluate

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 17, 2023 •
edited

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Feb 17, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (732a6ee) 99.90% compared to head (fd89539) 99.90%.

❗ Current head fd89539 differs from pull request most recent head de49667. Consider uploading reports for the commit de49667 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #1781   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          61       61           
  Lines        6103     6104    +1     
  Branches     1482     1482           
=======================================
+ Hits         6097     6098    +1     
  Misses          6        6
Impacted Files Coverage Δ
src/ParseFile.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested review from mtrezza and a team February 17, 2023 20:50
@mtrezza
Copy link
Member

mtrezza commented Feb 18, 2023 •
edited

Seems there are still commits being made, so removing the review request

@mtrezza mtrezza removed request for a team and mtrezza February 18, 2023 21:32
@dplewis
Copy link
Member Author

dplewis commented Feb 24, 2023

@mtrezza The reason for the commits is because this PR introduces a flaky test and I don't know why. Can you re-run the CI?

@mtrezza
Copy link
Member

mtrezza commented Feb 24, 2023

Sure, rerunning...

@mtrezza mtrezza changed the title fix: Parse.File.cancel retry attempts fix: Parse.File.cancel starts new attempt to save file Mar 1, 2023
mtrezza
mtrezza approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit b755e42 into parse-community:alpha Mar 1, 2023
parseplatformorg pushed a commit that referenced this pull request Mar 1, 2023
@semantic-release-bot
chore(release): 4.1.0-alpha.2 [skip ci]
fd108bf 
# [4.1.0-alpha.2](4.1.0-alpha.1...4.1.0-alpha.2) (2023-03-01)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 1, 2023
@dplewis dplewis deleted the file-cancel branch March 5, 2023 02:41
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
@semantic-release-bot
chore(release): 4.2.0-beta.1 [skip ci]
0f6df9d 
# [4.2.0-beta.1](4.1.0...4.2.0-beta.1) (2023-05-01)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
@semantic-release-bot
chore(release): 4.2.0-alpha.1 [skip ci]
89ad09d 
# [4.2.0-alpha.1](4.1.0...4.2.0-alpha.1) (2023-05-01)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
8e9afc6 
# [4.2.0](4.1.0...4.2.0) (2023-09-15)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@dblythy dblythy Awaiting requested review from dblythy

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsuccessful cancellation of Parse File
3 participants
@dplewis @mtrezza @parseplatformorg