Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Parse.User.loginAs #1875

Merged
merged 2 commits into from
Apr 28, 2023
Merged

feat: Add Parse.User.loginAs #1875

merged 2 commits into from
Apr 28, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 28, 2023

Pull Request

Issue

Later versions of Parse Server parse-community/parse-server#7406. Given a userId and the master key, one can become logged in as the user associated to the userId provided. This PR adds the PHP Parse SDK method to call the Parse Server endpoint.

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (24c03dd) 99.88% compared to head (636eaa4) 99.88%.

❗ Current head 636eaa4 differs from pull request most recent head 31bbe17. Consider uploading reports for the commit 31bbe17 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1875   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          61       61           
  Lines        6117     6131   +14     
  Branches     1485     1487    +2     
=======================================
+ Hits         6110     6124   +14     
  Misses          7        7           
Impacted Files Coverage Δ
src/ParseUser.js 99.60% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza April 28, 2023 03:43
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 381fcfc into parse-community:alpha Apr 28, 2023
7 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 28, 2023
# [4.1.0-alpha.4](4.1.0-alpha.3...4.1.0-alpha.4) (2023-04-28)

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 28, 2023
@dplewis dplewis deleted the loginAs branch April 28, 2023 21:00
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
# [4.2.0-beta.1](4.1.0...4.2.0-beta.1) (2023-05-01)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
# [4.2.0-alpha.1](4.1.0...4.2.0-alpha.1) (2023-05-01)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
# [4.2.0](4.1.0...4.2.0) (2023-09-15)

### Bug Fixes

* `Parse.File.cancel` starts new attempt to save file ([#1781](#1781)) ([b755e42](b755e42))

### Features

* Add `Parse.User.loginAs` ([#1875](#1875)) ([381fcfc](381fcfc))
* Add `ParseQuery.watch` to trigger LiveQuery only on update of specific fields ([#1839](#1839)) ([7479343](7479343))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants