Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add query methods fetchWithInclude and fetchAllWithInclude #512

Merged
merged 4 commits into from
May 13, 2023
Merged

feat: Add query methods fetchWithInclude and fetchAllWithInclude #512

merged 4 commits into from
May 13, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 12, 2023

New Pull Request Checklist

Issue Description

Adds missing functionality. These fetches are in the JS SDK.

Closes: #401

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 12, 2023 •
edited

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 12, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ee2a5fa) 98.61% compared to head (e99d692) 98.62%.

❗ Current head e99d692 differs from pull request most recent head 9b33abe. Consider uploading reports for the commit 9b33abe to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #512   +/-   ##
=========================================
  Coverage     98.61%   98.62%           
- Complexity     1068     1072    +4     
=========================================
  Files            38       38           
  Lines          3241     3264   +23     
=========================================
+ Hits           3196     3219   +23     
  Misses           45       45
Impacted Files Coverage Δ
src/Parse/ParseClient.php 95.31% <ø> (ø)
src/Parse/ParseObject.php 97.33% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 12, 2023 20:12
@mtrezza mtrezza changed the title feat: Add fetchWithInclude and fetchAllWithInclude feat: Add query commands fetchWithInclude and fetchAllWithInclude May 13, 2023
@mtrezza mtrezza changed the title feat: Add query commands fetchWithInclude and fetchAllWithInclude feat: Add query methods fetchWithInclude and fetchAllWithInclude May 13, 2023
mtrezza
mtrezza approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 0570f15 into parse-community:master May 13, 2023
5 checks passed
parseplatformorg pushed a commit that referenced this pull request May 13, 2023
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
8eee29f 
# [2.3.0](2.2.0...2.3.0) (2023-05-13)

### Features

* Add query methods `fetchWithInclude` and `fetchAllWithInclude` ([#512](#512)) ([0570f15](0570f15))
@parseplatformorg
Copy link

🎉 This change has been released in version 2.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
@dplewis dplewis deleted the fetch-with-include branch May 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version Edit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roadmap
3 participants
@dplewis @parseplatformorg @mtrezza