feat: upgrade to latest Google Cloud Storage library #40
Conversation
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 1 1
Lines 67 67
=======================================
Hits 33 33
Misses 34 34
Continue to review full report at Codecov.
|
|
@Moumouls There are relatively few changes in this PR, considering that |
|
@lebenitza could you try out this PR and let us know whether it works? |
|
@Moumouls thank you for the PR! @mtrezza I will try to find some time to test this. I will test it on GKE, I want to make sure Workload Identity works and see how it behaves with directAccess on and off. |
|
Hi @lebenitza |
|
@mtrezza @lebenitza I can confirm that everything works correctly. I succeed to upload some files on via Google Cloud Run to GCS. I can also confirm that workload identity works correctly when directAccess is off. All files are private on GCS. We are good to go here |
mtrezza
changed the title
|
Great, just to confirm, can we merge and release this as a feature version (1.2.0) because despite the GCS upgrade from 1.x to 6.x there is no breaking change for Parse Server? |
|
No breaking changes @mtrezza google has not changed interfaces/features used by the GCS adapter. 1.2 is okay |
# [1.2.0](1.1.3...1.2.0) (2022-08-05) ### Features * upgrade to latest Google Cloud Storage library ([#40](#40)) ([00b89b7](00b89b7))
|
🎉 This change has been released in version 1.2.0 |
# 1.0.0 (2023-07-05) ### Bug Fixes * security upgrade qs from 6.5.2 to 6.5.3 ([parse-community#44](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/44)) ([c9473d1](c9473d1)) ### Features * upgrade to latest Google Cloud Storage library ([parse-community#40](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/40)) ([00b89b7](00b89b7)) ### Reverts * Revert "Bump semantic-release from 17.4.6 to 19.0.3" (parse-community#37) ([d451ef4](d451ef4)), closes [parse-community#37](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/37) [parse-community#36](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/36)
# 1.0.0 (2023-07-05) ### Bug Fixes * security upgrade qs from 6.5.2 to 6.5.3 ([parse-community#44](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/44)) ([c9473d1](c9473d1)) ### Features * upgrade to latest Google Cloud Storage library ([parse-community#40](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/40)) ([00b89b7](00b89b7)) ### Reverts * Revert "Bump semantic-release from 17.4.6 to 19.0.3" (parse-community#37) ([d451ef4](d451ef4)), closes [parse-community#37](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/37) [parse-community#36](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/36)
# 1.0.0 (2023-07-05) ### Bug Fixes * security upgrade qs from 6.5.2 to 6.5.3 ([parse-community#44](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/44)) ([c9473d1](c9473d1)) ### Features * upgrade to latest Google Cloud Storage library ([parse-community#40](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/40)) ([00b89b7](00b89b7)) ### Reverts * Revert "Bump semantic-release from 17.4.6 to 19.0.3" (parse-community#37) ([d451ef4](d451ef4)), closes [parse-community#37](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/37) [parse-community#36](https://github.com/meo-chuot/parse-server-gcs-adapter/issues/36)
No description provided.