Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info/warning for GUI updates #493

Merged
merged 6 commits into from
Jan 8, 2018
Merged

Info/warning for GUI updates #493

merged 6 commits into from
Jan 8, 2018

Conversation

AllienWorks
Copy link
Member

@AllienWorks AllienWorks commented Dec 11, 2017

Preview


@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.31% when pulling e0ba027 on feature/alerts into 071ec6c on restructure.

@kewde kewde changed the base branch from restructure to dev December 11, 2017 23:56
@kewde
Copy link
Collaborator

kewde commented Dec 11, 2017

I like this.. Will need a bit of a change in the backend I believe.

@AllienWorks
Copy link
Member Author

(Rebased on top of dev)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.273% when pulling 282a23e on feature/alerts into 27199aa on dev.

@cryptoguard
Copy link

Another cool function would be to be able to push text messages to users.
i.e. "Don't forget to vote for community proposal #42 before block #50000"

@AllienWorks AllienWorks added this to the 1.2 milestone Dec 13, 2017
@pciavald
Copy link
Contributor

@cryptoguard it's another functionality, maybe open an issue ?

@AllienWorks AllienWorks modified the milestones: 1.2, 1.1 Jan 4, 2018
@AllienWorks AllienWorks mentioned this pull request Jan 4, 2018
2 tasks
@pciavald pciavald changed the title Info/warning notifications Info/warning for GUI updates Jan 4, 2018
@pciavald
Copy link
Contributor

pciavald commented Jan 4, 2018

@AllienWorks buttons logos were lost rebasing dev

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.872% when pulling b187088 on feature/alerts into bec1e13 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.085% when pulling 744ad2b on feature/alerts into e863851 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.085% when pulling 744ad2b on feature/alerts into e863851 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.085% when pulling 80dab0c on feature/alerts into e863851 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 47.104% when pulling 0865160 on feature/alerts into e863851 on dev.

@AllienWorks
Copy link
Member Author

Nice work @anandsinghparihar! The notification now shows only when the version on GH is newer than your currently running one.

After code review, this is ready to be merged.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 46.64% when pulling ba63e41 on feature/alerts into 0ad510c on dev.

@pciavald
Copy link
Contributor

pciavald commented Jan 5, 2018

I tried 1.0.1 and 1.0.0 in package.json and i get nothing... am I doing something wrong ?

@AllienWorks
Copy link
Member Author

@pciavald I tried 1.0.1 and 1.0.0 in package.json and i get nothing... am I doing something wrong ?

Yes :) Because the latest release on GH is 1.0.0, you should try something like 0.9.0 for example..

@anandsinghparihar
Copy link
Contributor

@pciavald please try lower value then 1.0.1 , because current version get from GitHub and its 1.0.1.

try
"version": "0.1.0",

@pciavald
Copy link
Contributor

pciavald commented Jan 8, 2018

Hahah, sorry guys, my bad.

@pciavald pciavald merged commit 290b211 into dev Jan 8, 2018
@pciavald pciavald deleted the feature/alerts branch January 8, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants