Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input clear button #611

Merged
merged 5 commits into from
Jan 12, 2018
Merged

Input clear button #611

merged 5 commits into from
Jan 12, 2018

Conversation

anandsinghparihar
Copy link
Contributor

@anandsinghparihar anandsinghparihar commented Jan 8, 2018

Add All search

Input with a clear button #610

Right now all search input doesn't have a clear button, we need to clear that input by backspace. so I hope we should add clear button.

here is a preview of a clear button :
input clear button

@anandsinghparihar anandsinghparihar added this to the 1.1 milestone Jan 8, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.432% when pulling 0b2e396 on input_clear_button into 7816aa9 on dev.

@AllienWorks
Copy link
Member

AllienWorks commented Jan 9, 2018

Styled.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.432% when pulling f6e13c4 on input_clear_button into 7816aa9 on dev.

@particl particl deleted a comment from anandsinghparihar Jan 9, 2018
@particl particl deleted a comment from AllienWorks Jan 9, 2018
@particl particl deleted a comment from anandsinghparihar Jan 9, 2018
@pciavald
Copy link
Contributor

pciavald commented Jan 9, 2018

@anandsinghparihar @AllienWorks I edited the thread conversations, these matters are better discussed on Matrix 👍 cheers :)

Copy link
Contributor

@pciavald pciavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @AllienWorks cross style is inconsistent
    • red cross
      • address book search
      • history clear all
    • white on red cross
      • closing modals
      • address book delete
      • send address clear
    • white on black cross
      • receive search
      • history search
  • @anandsinghparihar can you please activate escape to clear & enter like in history search

@anandsinghparihar
Copy link
Contributor Author

@pciavald

can you please activate escape to clear & enter like in history search
Enter is not required because of all search fire on input changes. I've added escape for clear search field.

@AllienWorks now you can work on the design part.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.432% when pulling cc5b16b on input_clear_button into 425000a on dev.

@AllienWorks
Copy link
Member

Restyled.

This is how icons are organized now:

  • part-circle-remove as "close/delete" (for closing modals, deleting entries)
  • part-clear-all as "clear" (e.g. here for clearing text from inputs or whole forms)
  • part-cross as "cancel"

I don't think we should unify all those 3 into 1; after all, there are differences between them. Those icons that aren't fixed according to this ^ are fixed already in #657 (FYI).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.432% when pulling 3829090 on input_clear_button into 425000a on dev.

@pciavald pciavald merged commit ad24ed4 into dev Jan 12, 2018
@AllienWorks AllienWorks deleted the input_clear_button branch January 13, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants