Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor passwordcomponent to show password for both text field using… #617

Merged
merged 5 commits into from
Jan 12, 2018
Merged

refactor passwordcomponent to show password for both text field using… #617

merged 5 commits into from
Jan 12, 2018

Conversation

vikas-cis-zz
Copy link

… one checkbox

#595

@vikas-cis-zz vikas-cis-zz mentioned this pull request Jan 8, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 46.48% when pulling f090948 on vikas-cis:refactor_password_component into cbd7582 on particl:dev.

pciavald
pciavald reviewed Jan 9, 2018
View reviewed changes
Copy link
Contributor

@pciavald pciavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable tab focus on the checkbox.

  • click field 1
  • tab
  • should be on field 2, but is on checkbox

pciavald
pciavald suggested changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@pciavald pciavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@vikas-cis-zz vikas-cis-zz self-assigned this Jan 12, 2018
@vikas-cis-zz vikas-cis-zz modified the milestones: 1.1, 1.2 Jan 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 46.48% when pulling 2bd2b33 on vikas-cis:refactor_password_component into cbd7582 on particl:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 46.785% when pulling 96a5737 on vikas-cis:refactor_password_component into 806953c on particl:dev.

@pciavald pciavald merged commit 3550cd9 into particl:dev Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pciavald pciavald pciavald approved these changes

Assignees

@vikas-cis-zz vikas-cis-zz

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vikas-cis-zz @coveralls @pciavald @vikas-cis