Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert settings page design into material #622

Closed

Conversation

anandsinghparihar
Copy link
Contributor

@anandsinghparihar anandsinghparihar commented Jan 9, 2018

Closes #582

@anandsinghparihar anandsinghparihar changed the title Convert seting page desing into material Convert settings page desing into material Jan 9, 2018
@anandsinghparihar anandsinghparihar changed the title Convert settings page desing into material Convert settings page design into material Jan 9, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 46.165% when pulling 27ee5a2 on anandsinghparihar:setting_page_design into cbd7582 on particl:dev.

@AllienWorks AllienWorks added this to the 1.2 milestone Jan 9, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 46.165% when pulling 3d52189 on anandsinghparihar:setting_page_design into cbd7582 on particl:dev.

@AllienWorks
Copy link
Member

I propose a new structure for the Settings page:

  • move Main > Staking, Transactions to separate tab (Main page is already crowded as it is..)
  • move whole Window to Main tab (too little options for own page)
  • add info to Help tab as per Help/Support page needed #540
  • add About page, which could contain some credits to used tech/code, current version display etc. & possibly even contributors ;)

What do you think?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 46.52% when pulling a93fb58 on anandsinghparihar:setting_page_design into cbd7582 on particl:dev.

@AllienWorks
Copy link
Member

Current preview: https://i.imgur.com/btjvUPY.mp4 (available also as a 10MB GIF :)

TODO

  • quite a lot the settings still needs to be connected to backend; I haven't tested all, but many of those don't work
  • we'll need to review all the items and hide the irrelevant (e.g. Secure messaging, which AFAIK isn't available anywhere in the GUI yet)
  • add a lot of stuff (from the top of my head stuff related to Cold staking etc.)
  • proof-reading and someone to actually come up with senseful descriptions and help texts! :)

@AllienWorks AllienWorks added PRG and removed GFX labels Jan 15, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 46.374% when pulling 2c6bbd0 on anandsinghparihar:setting_page_design into cbd7582 on particl:dev.

@pciavald pciavald modified the milestones: 1.2.0, 1.1.1 Jan 29, 2018
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage decreased (-0.2%) to 45.375% when pulling d2c04de on anandsinghparihar:setting_page_design into 7e7ae66 on particl:dev.

@pciavald pciavald changed the base branch from dev to develop February 3, 2018 00:10
@AllienWorks AllienWorks mentioned this pull request Feb 19, 2018
@kewde
Copy link
Collaborator

kewde commented Mar 17, 2018

Going to merge, better to have this in the codebase.
I've hidden the settings page for now

@AllienWorks
Copy link
Member

@kewde yes please, the merge of this is long overdue. I've defined some SCSS templates etc. which I would like to use globally in app. So by me yes, definitely merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize GUI Settings page
5 participants