cold staking widget state different scenarios fixing #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pciavald
suggested changes
Jan 9, 2018
There was a problem hiding this comment.
unlock widget does not have the right behaviour
Wallet should be unlocked for staking only when unlocking the widget, instead of the current fully unlocked with timer.
unlock wallet for staking only does not have the right behaviour
When unlocking for staking only, coldstaking is at 0%. Locking and fully unlocking the wallet updates the coldstaking at 100% (real here).
| @@ -64,6 +65,9 @@ export class ColdstakeComponent implements OnInit { | |||
| if (this.coldstakeProgress < 100) { | |||
| setTimeout(this.rpc_progressLoop.bind(this), 1000); | |||
| } | |||
| if (this.coldstakeProgress === 100) { | |||
| this.activation = 'Activated'; | |||
There was a problem hiding this comment.
we still need to poll here in case there's a new transaction after full activation
…et instead fully unlock
pciavald
approved these changes
Jan 12, 2018
|
Perfect, @vikas-cis . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#620