Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal fixes & fixed consistency of icons #657

Merged
merged 3 commits into from
Jan 12, 2018
Merged

modal fixes & fixed consistency of icons #657

merged 3 commits into from
Jan 12, 2018

Conversation

AllienWorks
Copy link
Member

@AllienWorks AllienWorks commented Jan 11, 2018

Mainly small GFX fixes and tweaks & solution to Henk's layout issue:

  • focus inputs when modals are opened
  • fixed layout on Address lookup & Verify/sign modals
  • hopefully fixed modals' content misalignment issues
  • disabled missing text selection on few places

- focus inputs when modals are opened
- fixed layout on Address lookup
@AllienWorks AllienWorks self-assigned this Jan 11, 2018
@HenkSwardt
Copy link
Contributor

I have tested this on my side as I was getting strange layout issues when creating a new wallet on dev.

Using Windows 10 64 bit and can confirm this resolved the issue.

@HenkSwardt HenkSwardt added this to the 1.1 milestone Jan 11, 2018
@vikas-cis-zz vikas-cis-zz self-requested a review January 11, 2018 14:39
@vikas-cis-zz
Copy link

I have tested and seems like modal still moving to left

screen shot 2018-01-11 at 8 16 22 pm
screen shot 2018-01-11 at 8 17 01 pm
screen shot 2018-01-11 at 8 17 30 pm

@AllienWorks
Copy link
Member Author

Hmm, too bad. At least some issue was fixed. We'll have to figure out another solution for @vikas-cis problem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.432% when pulling 78bcf0a on gfx/tweaks into 425000a on dev.

@pciavald pciavald merged commit 23d21df into dev Jan 12, 2018
@pciavald pciavald deleted the gfx/tweaks branch January 12, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants