Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Sign/verify > Address lookup issue #662

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Resolve Sign/verify > Address lookup issue #662

merged 2 commits into from
Jan 15, 2018

Conversation

anandsinghparihar
Copy link
Contributor

@anandsinghparihar anandsinghparihar commented Jan 12, 2018 •
edited
Loading

Sign/verify > Address lookup not working #658

In Sign message: Own address display
In Verify message: Saved address (other user addresses save from address book)

@anandsinghparihar anandsinghparihar added this to the 1.1 milestone Jan 12, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 46.393% when pulling a4128ef on addresses_lookup_issue into 425000a on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 46.746% when pulling 8b93656 on addresses_lookup_issue into 23d21df on dev.

@vikas-cis-zz
Copy link

vikas-cis-zz commented Jan 15, 2018 •
edited
Loading

screen shot 2018-01-15 at 4 53 50 pm

Seems like pagination is not reseting on the send page (address lookup) @anandsinghparihar Can you please check
Thanks

@anandsinghparihar
Copy link
Contributor Author

@vikas-cis nice catch, changes pushed !!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 46.746% when pulling 2799d9a on addresses_lookup_issue into 23d21df on dev.

@vikas-cis-zz
Copy link

Thanks @anandsinghparihar works fine now 👍

@pciavald pciavald merged commit 42b096f into dev Jan 15, 2018
@pciavald pciavald deleted the addresses_lookup_issue branch January 15, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pciavald pciavald Awaiting requested review from pciavald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anandsinghparihar @coveralls @vikas-cis-zz @pciavald