Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow block confirmation updated fix #674

Merged
merged 1 commit into from
Jan 16, 2018
Merged

slow block confirmation updated fix #674

merged 1 commit into from
Jan 16, 2018

Conversation

vikas-cis-zz
Copy link

@vikas-cis-zz vikas-cis-zz self-assigned this Jan 15, 2018
@vikas-cis-zz vikas-cis-zz added this to the 1.1 milestone Jan 15, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 46.706% when pulling 2775ad0 on vikas-cis:blocks_confirmation_slow_update into 23d21df on particl:dev.

@pciavald
Copy link
Contributor

Confirmations now work, but unexpectedly transactions now appear in reverse order !

screenshot_20180115_231258

pciavald
pciavald previously requested changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@pciavald pciavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@vikas-cis-zz
Copy link
Author

@pciavald let me have a look

Thanks

@vikas-cis-zz vikas-cis-zz force-pushed the blocks_confirmation_slow_update branch from 2775ad0 to 915d494 Compare January 16, 2018 09:45
@vikas-cis-zz
Copy link
Author

@pciavald I have started with fresh wallet and done some transactions on it but couldn't able to reproduce the issue.
screen shot 2018-01-16 at 3 17 05 pm

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 46.757% when pulling 915d494 on vikas-cis:blocks_confirmation_slow_update into c0ff379 on particl:dev.

@AllienWorks AllienWorks dismissed pciavald’s stale review January 16, 2018 12:09

Tested, works for me (quick update & right order). Also some changes made.. Can you test again @pciavald?

@pciavald
Copy link
Contributor

idk why, it seems to work now...

@pciavald pciavald merged commit f8a2793 into particl:dev Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pciavald pciavald pciavald left review comments

Assignees

@vikas-cis-zz vikas-cis-zz

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vikas-cis-zz @coveralls @pciavald @AllienWorks @vikas-cis