Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed window resizing issue #713

Merged
merged 4 commits into from
Feb 5, 2018
Merged

fixed window resizing issue #713

merged 4 commits into from
Feb 5, 2018

Conversation

AllienWorks
Copy link
Member

  • locked window's min-width and min-height (on the same sizes as default width/height)
  • enabled resizing & fullscreen

fixed window resizing issue
5c8ee85 
locked window's min-width and min-height, enabled resizing/fullscreen
@AllienWorks AllienWorks added this to the 1.2 milestone Jan 18, 2018
@AllienWorks AllienWorks self-assigned this Jan 18, 2018
@AllienWorks
Copy link
Member Author

Don't merge into 1.1!

@particl particl deleted a comment from coveralls Jan 18, 2018
@particl particl deleted a comment from coveralls Jan 18, 2018
@pciavald
Copy link
Contributor

why not for 1.1 ?

@AllienWorks
Copy link
Member Author

@pciavald why not for 1.1 ?

Responsivity isn't solved for larger widths. You can pull and try for yourself.

@pciavald pciavald modified the milestones: 1.2.0, 1.1.1 Jan 29, 2018
@pciavald pciavald changed the base branch from dev to develop February 3, 2018 00:09
@pciavald
Copy link
Contributor

pciavald commented Feb 3, 2018

@AllienWorks can you please fix conflicting files ? :)

@AllienWorks
Copy link
Member Author

@pciavald done.

@kewde kewde merged commit 54ce6e1 into develop Feb 5, 2018
@kewde kewde deleted the fix/window-resizing branch February 5, 2018 11:54
@AllienWorks
Copy link
Member Author

@kewde why did you merge this? :|
I didn't want this in 1.1, still needs fixing of responsivity for larger widths (see conversation ^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewde kewde kewde approved these changes

Assignees

@AllienWorks AllienWorks

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AllienWorks @pciavald @kewde