Feature/balance #9

kewde · 2017-06-16T21:18:34Z

Testing coverage

unified service to store all balances single number representing balance + some magic to split balances into two pieces TODO: Single service for all balance components

Test subscription (update after 5 seconds) remove junk

coveralls · 2017-06-16T21:38:45Z

Coverage increased (+0.7%) to 74.722% when pulling 5af75c9 on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-16T22:06:22Z

Coverage decreased (-4.04%) to 70.0% when pulling 21ad574 on feature/balance into 0d23dc0 on master.

Fixed balances UI now does: 5.00000 => 5 (without .)

coveralls · 2017-06-18T12:30:12Z

Coverage increased (+0.08%) to 74.114% when pulling 0f037e1 on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-18T12:43:59Z

Coverage increased (+0.08%) to 74.114% when pulling 0f037e1 on feature/balance into 0d23dc0 on master.

rynomster · 2017-06-19T05:31:43Z

Please fix the linter issues, as this is not acceptable.

ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[52, 48]: comment must start with a space
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[127, 69]: comment must start with a space
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[2, 39]: This import is blacklisted, import a submodule instead
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[133, 3]: Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[61, 9]: Identifier 'b' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[126, 9]: Identifier 'total_balance' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[127, 9]: Identifier 'public_balance' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[128, 9]: Identifier 'private_balance' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[129, 9]: Identifier 'staked_balance' is never reassigned; use 'const' instead of 'let'.
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[126, 30]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[127, 31]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[127, 49]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[128, 32]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[129, 31]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[134, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[135, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[136, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[137, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[138, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[139, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[140, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[141, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[142, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[143, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[144, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[145, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[146, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[146, 25]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[147, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[150, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[151, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[152, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[153, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[154, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[155, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[156, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[157, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[158, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[159, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[160, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[161, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[162, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[162, 25]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.service.ts[163, 5]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[44, 7]: comment must start with a space
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[53, 47]: missing whitespace
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[56, 26]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[56, 32]: " should be '
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[52, 24]: expected parameter: 'retzero' to have a typedef
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[10, 49]: missing whitespace
ERROR: /home/travis/build/particl/partgui/src/app/wallet/balances/balance.component.ts[53, 7]: missing whitespace

rynomster · 2017-06-19T05:32:57Z

src/app/wallet/balances/balance.service.ts

+      }
+    }
+
+    constructor(total: number, pub: number, priv: number, stake: number) {


We are duplicating references here.. Lefts try and keep one of each variable..

rynomster · 2017-06-19T05:33:23Z

src/app/wallet/balances/balance.service.ts


-  typeOfBalance: string;
+    setTimeout(_ => this.rpc_loadBalance()); //load initial balances


bad comment, linter issue

coveralls · 2017-06-19T16:39:24Z

Coverage increased (+0.4%) to 74.468% when pulling 37e2836 on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-19T16:46:25Z

Coverage decreased (-4.6%) to 69.415% when pulling 7760065 on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-20T01:31:12Z

Coverage decreased (-2.7%) to 71.369% when pulling 0a075a5 on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-20T11:23:17Z

Coverage increased (+1.8%) to 75.867% when pulling 508cdfa on feature/balance into 0d23dc0 on master.

coveralls · 2017-06-22T18:04:49Z

Coverage decreased (-1.03%) to 73.005% when pulling 8a88ce0 on feature/balance into 0d23dc0 on master.

It can connect to RPC. It lacks error handling and quite a few features, but its a start

coveralls · 2017-06-29T09:09:11Z

Coverage decreased (-3.5%) to 70.874% when pulling 865a76e on feature/balance into 5c49b8a on master.

coveralls · 2017-06-29T09:16:58Z

Coverage decreased (-3.5%) to 70.874% when pulling d207c9c on feature/balance into 5c49b8a on master.

Market beta

kewde added 4 commits June 16, 2017 16:31

Moved to observables

64b7fe2

unified service to store all balances single number representing balance + some magic to split balances into two pieces TODO: Single service for all balance components

Use one shared service

972a90d

Test subscription (update after 5 seconds) remove junk

Fixed lint errors

8af5f49

Fix karma test

5af75c9

kewde added 3 commits June 16, 2017 23:43

Going the extra mile to make Travis

f9e9d68

Travis, happy now!

509c7a6

fix ondestroy

21ad574

kewde added 2 commits June 18, 2017 13:12

Undo "Observable, Observer from rxjs/..." -> Broke overview

c0c57c1

Added real JSON test data, custom deserialize

0f037e1

Fixed balances UI now does: 5.00000 => 5 (without .)

rynomster reviewed Jun 19, 2017

View reviewed changes

Fix lint issue, except one that bugs

37e2836

Fixes lint, breaks build

7760065

Remove redundant constructor initialisation

0a075a5

kewde added 2 commits June 20, 2017 13:17

Prepared JSON input for balance service

1dc09db

fix lint

508cdfa

add rpc_getParameters()

8a88ce0

rynomster added 3 commits June 23, 2017 15:19

RPC Service start

d58d08d

It can connect to RPC. It lacks error handling and quite a few features, but its a start

Merge branch 'feature/balance' into feature/rpc

861c5b6

RPCService - Lint changes + context fix

5fe8ce2

rynomster added 3 commits June 26, 2017 09:03

Merge branch 'feature/rpc' into feature/balance

7e74964

Call callback with instance context

244b953

Fix tests - Enable RPC service

865a76e

Fix lint error

d207c9c

rynomster merged commit 547641f into master Jun 30, 2017

rynomster deleted the feature/balance branch July 10, 2017 14:43

zaSmilingIdiot pushed a commit that referenced this pull request Feb 28, 2022

Merge pull request #9 from particl/market-beta

7037e4b

Market beta

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/balance #9

Feature/balance #9

kewde commented Jun 16, 2017

coveralls commented Jun 16, 2017

coveralls commented Jun 16, 2017

coveralls commented Jun 18, 2017

coveralls commented Jun 18, 2017

rynomster commented Jun 19, 2017

rynomster Jun 19, 2017

rynomster Jun 19, 2017

coveralls commented Jun 19, 2017

coveralls commented Jun 19, 2017

coveralls commented Jun 20, 2017

coveralls commented Jun 20, 2017

coveralls commented Jun 22, 2017

coveralls commented Jun 29, 2017

coveralls commented Jun 29, 2017


		typeOfBalance: string;
		setTimeout(_ => this.rpc_loadBalance()); //load initial balances

Feature/balance #9

Feature/balance #9

Conversation

kewde commented Jun 16, 2017

coveralls commented Jun 16, 2017

coveralls commented Jun 16, 2017

coveralls commented Jun 18, 2017

coveralls commented Jun 18, 2017

rynomster commented Jun 19, 2017

rynomster Jun 19, 2017

Choose a reason for hiding this comment

rynomster Jun 19, 2017

Choose a reason for hiding this comment

coveralls commented Jun 19, 2017

coveralls commented Jun 19, 2017

coveralls commented Jun 20, 2017

coveralls commented Jun 20, 2017

coveralls commented Jun 22, 2017

coveralls commented Jun 29, 2017

coveralls commented Jun 29, 2017