Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When_subscribing_to_a_base_event_from_different_publishers test fails #30

Closed
johnsimons opened this issue Apr 29, 2014 · 6 comments
Closed

Comments

@johnsimons
Copy link
Member

@andreasohlund does RabbitMQ support this use case?

This test fails both locally and on the build server.

Do we need to exclude it from Rabbit?

@johnsimons johnsimons added the bug label Apr 29, 2014
@johnsimons
Copy link
Member Author

This seems to be failing due to a timing issue.
If I add a break point the test actually passes.

@andreasohlund any ideas?

@andreasohlund
Copy link
Member

Can we modify the test to "wait" until the subscriptions are present?

On Wed, Apr 30, 2014 at 1:22 AM, John Simons notifications@github.comwrote:

This seems to be failing due to a timing issue.
If I add a break point the test actually passes.

@andreasohlund https://github.com/andreasohlund any ideas?


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-41744333
.

@johnsimons
Copy link
Member Author

How do we go about doing that in a generic non rabbit way?

On Wednesday, April 30, 2014, Andreas Öhlund notifications@github.com
wrote:

Can we modify the test to "wait" until the subscriptions are present?

On Wed, Apr 30, 2014 at 1:22 AM, John Simons <notifications@github.comjavascript:_e(%7B%7D,'cvml','notifications@github.com');>wrote:

This seems to be failing due to a timing issue.
If I add a break point the test actually passes.

@andreasohlund https://github.com/andreasohlund any ideas?


Reply to this email directly or view it on GitHub<
https://github.com/Particular/NServiceBus.RabbitMQ/issues/30#issuecomment-41744333>

.


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-41773492
.

@andreasohlund
Copy link
Member

Perhaps add a "IsSubscribed" hook in the test framework that just returns
true. Then each transport can override it as needed?

On Wed, Apr 30, 2014 at 11:10 AM, John Simons notifications@github.comwrote:

How do we go about doing that in a generic non rabbit way?

On Wednesday, April 30, 2014, Andreas Öhlund notifications@github.com
wrote:

Can we modify the test to "wait" until the subscriptions are present?

On Wed, Apr 30, 2014 at 1:22 AM, John Simons <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>wrote:

This seems to be failing due to a timing issue.
If I add a break point the test actually passes.

@andreasohlund https://github.com/andreasohlund any ideas?


Reply to this email directly or view it on GitHub<

https://github.com/Particular/NServiceBus.RabbitMQ/issues/30#issuecomment-41744333>

.


Reply to this email directly or view it on GitHub<
https://github.com/Particular/NServiceBus.RabbitMQ/issues/30#issuecomment-41773492>

.


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-41775736
.

@johnsimons
Copy link
Member Author

Sorry @andreasohlund haven't seen the light yet.
Can you show me some code?

@andreasohlund
Copy link
Member

Fixed on the core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants