feat: Add optional role parameter for cert-manager add-on #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksiimorozenko
requested review from
ArchiFleKs and
rguichard
and removed request for
a team
Signed-off-by: Oleksii Morozenko <oleksii.morozenko@gmail.com>
Signed-off-by: Oleksii Morozenko <oleksii.morozenko@gmail.com>
oleksiimorozenko
changed the title
ArchiFleKs
approved these changes
Jun 21, 2023
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional role parameter for cert-manager add-on
Description
In case someone's doing certificates cross-account, the following resources assigning/assuming roles and permissions are needed
For example, cert-manager needs to create a certificate in the local account using DNS challenge, but there's no Route53 zone in this account
In order to make the challenge, it needs to use the IRSA role which can assume the role in another account where the Route53 zone lives. In turn, this role from the account holding Route53 zone should allow being assumed by this IRSA role
But moreover, the IRSA role says that cert-manager can assume the role, but not giving the instruction to do this
That's why a custom ClusterIssuer resource is needed with the added role parameter which is currently not supported by the root module
Checklist